From: "Peter Hüwe" <PeterHuewe@gmx.de>
To: Kent Yoder <key@linux.vnet.ibm.com>
Cc: Joe Perches <joe@perches.com>, Rajiv Andrade <mail@srajiv.net>,
Marcel Selhorst <tpmdd@selhorst.net>,
Sirrix AG <tpmdd@sirrix.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v3] char/tpm: Use true and false for bools
Date: Thu, 29 Nov 2012 23:16:55 +0100 [thread overview]
Message-ID: <201211292316.55305.PeterHuewe@gmx.de> (raw)
In-Reply-To: <20121129220811.GA32514@ennui.austin.ibm.com>
Am Donnerstag, 29. November 2012, 23:08:11 schrieb Kent Yoder:
> On Thu, Nov 29, 2012 at 01:54:52PM -0800, Joe Perches wrote:
> > >
> > > - itpm = (probe == 0) ? 0 : 1;
> > > + itpm = !!probe;
> >
> > Even more trivia:
> >
> > This !! isn't necessary as ints assigned to bool are converted
> > by the compiler to 0 or 1.
>
> Good to know, thanks Joe!
So v2 is fine.
Peter
prev parent reply other threads:[~2012-11-29 22:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 0:20 [PATCH] char/tpm: Use true and false for bools Peter Huewe
2012-11-29 0:25 ` Al Viro
2012-11-29 0:39 ` [PATCH v2] " Peter Huewe
2012-11-29 0:42 ` [PATCH] " Peter Huewe
2012-11-29 16:06 ` Kent Yoder
2012-11-29 21:08 ` [PATCH v3] " Peter Huewe
2012-11-29 21:54 ` Joe Perches
2012-11-29 22:08 ` Kent Yoder
2012-11-29 22:16 ` Peter Hüwe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201211292316.55305.PeterHuewe@gmx.de \
--to=peterhuewe@gmx.de \
--cc=joe@perches.com \
--cc=key@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@srajiv.net \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
--cc=tpmdd@sirrix.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.