From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@parisplace.org>
Cc: Pavel Roskin <proski@gnu.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SE-Linux <selinux@tycho.nsa.gov>
Subject: Re: Bisected regression: iterate_fd() selinux change affects flash plugin
Date: Fri, 30 Nov 2012 04:02:40 +0000 [thread overview]
Message-ID: <20121130040240.GC4939@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20121130034034.GB4939@ZenIV.linux.org.uk>
On Fri, Nov 30, 2012 at 03:40:34AM +0000, Al Viro wrote:
> The bug is real, but Pavel's patch is all wrong. The problem is in the
> argument; we should pass descriptor number, not descriptor + 1. And fixing
> that (in iterator_fd() itself) makes all callbacks work as they ought to.
>
> PS: Pavel, the life is painful enough as it is, no need to involve BZ into
> it. Next time you need to post a patch, please do just that, especially
> when it's so short, OK?
See tonight's vfs.git#for-linus; the head is at commit a77cfcb.
next prev parent reply other threads:[~2012-11-30 4:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 14:14 Bisected regression: iterate_fd() selinux change affects flash plugin Pavel Roskin
2012-11-12 4:50 ` Pavel Roskin
2012-11-12 4:50 ` Pavel Roskin
2012-11-12 15:20 ` Eric Paris
2012-11-12 15:20 ` Eric Paris
2012-11-12 16:57 ` Pavel Roskin
2012-11-12 16:57 ` Pavel Roskin
2012-11-16 19:58 ` Eric Paris
2012-11-16 19:58 ` Eric Paris
2012-11-30 3:40 ` Al Viro
2012-11-30 4:02 ` Al Viro [this message]
2012-11-30 15:20 ` Pavel Roskin
2012-11-30 15:20 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130040240.GC4939@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.