From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: YAMANE Toshiaki <yamanetoshi@gmail.com>,
Joe Perches <joe@perches.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging/serqt_usb2: Refactor qt_status_change_check() in serqt_usb2.c
Date: Fri, 30 Nov 2012 11:25:27 +0300 [thread overview]
Message-ID: <20121130082527.GU11248@mwanda> (raw)
In-Reply-To: <20121130021026.GB2056@kroah.com>
On Thu, Nov 29, 2012 at 06:10:26PM -0800, Greg Kroah-Hartman wrote:
> On Thu, Nov 29, 2012 at 01:57:56PM +0900, YAMANE Toshiaki wrote:
> >
> > - ProcessLineStatus(qt_port, data[i + 3]);
> > -
> > i += 3;
> > + ProcessLineStatus(qt_port, data[i]);
>
> I think you just changed the logic in this function, didn't you?
This should be ok. The i += 3 was there in the original, it's just
moved up a line.
regards,
dan carpenter
next prev parent reply other threads:[~2012-11-30 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 4:57 [PATCH] staging/serqt_usb2: Refactor qt_status_change_check() in serqt_usb2.c YAMANE Toshiaki
2012-11-30 2:10 ` Greg Kroah-Hartman
2012-11-30 5:25 ` YAMANE Toshiaki
2012-11-30 8:25 ` Dan Carpenter [this message]
2012-11-30 12:53 ` YAMANE Toshiaki
-- strict thread matches above, loose matches on Subject: below --
2012-11-16 20:19 YAMANE Toshiaki
2012-11-16 20:58 ` Dan Carpenter
2012-11-17 1:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130082527.GU11248@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yamanetoshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.