All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: Randy Dunlap <rdunlap@infradead.org>,
	Rob Herring <rob.herring@calxeda.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree-discuss@lists.ozlabs.org,
	Ville Syrjala <syrjala@sci.fi>
Subject: Re: [PATCH -next] of: export "allnodes" to fixx w1-gpio.c modular build
Date: Fri, 30 Nov 2012 09:54:33 +0000	[thread overview]
Message-ID: <20121130095433.9F4743E070C@localhost> (raw)
In-Reply-To: <50B7F30C.1060105@infradead.org>

On Thu, 29 Nov 2012 15:43:08 -0800, Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build when CONFIG_W1_MASTER_GPIO=m by exporting "allnodes".
> 
> ERROR: "allnodes" [drivers/w1/masters/w1-gpio.ko] undefined!
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Ville Syrjala <syrjala@sci.fi>
> ---
>  drivers/of/base.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20121129.orig/drivers/of/base.c
> +++ linux-next-20121129/drivers/of/base.c
> @@ -46,6 +46,7 @@ struct alias_prop {
>  static LIST_HEAD(aliases_lookup);
>  
>  struct device_node *allnodes;
> +EXPORT_SYMBOL(allnodes);

Makes sense, but I don't like exporting such a generic name. I'm picking
up the patch but renaming s/allnodes/of_allnodes/ in the process.

g.

  reply	other threads:[~2012-11-30  9:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-29  6:40 linux-next: Tree for Nov 29 Stephen Rothwell
2012-11-29  6:40 ` Stephen Rothwell
2012-11-29 23:43 ` [PATCH -next] of: export "allnodes" to fixx w1-gpio.c modular build Randy Dunlap
2012-11-30  9:54   ` Grant Likely [this message]
2012-11-30  0:05 ` linux-next: Tree for Nov 29 (netlabel) Randy Dunlap
2012-11-30 15:19   ` Paul Moore
2012-11-30 15:31     ` Paul Moore
2012-11-30 16:55       ` Randy Dunlap
2012-11-30 17:22         ` Casey Schaufler
2012-11-30 17:28         ` [PATCH] Smack: Add missing depends on INET in Kconfig Casey Schaufler
2012-11-30 17:40           ` Randy Dunlap
2012-11-30 18:43             ` David Miller
2012-11-30 18:47               ` Casey Schaufler
2012-11-30 18:43             ` Paul Moore
2012-11-30 22:01           ` Eric Paris
2012-11-30 22:18             ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121130095433.9F4743E070C@localhost \
    --to=grant.likely@secretlab.ca \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=rob.herring@calxeda.com \
    --cc=sfr@canb.auug.org.au \
    --cc=syrjala@sci.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.