From: Samuel Ortiz <sameo@linux.intel.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
Fabio Estevam <fabio.estevam@freescale.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: da9052-core: Fix interrupts reported to mfd child devices
Date: Fri, 30 Nov 2012 12:04:38 +0100 [thread overview]
Message-ID: <20121130110438.GO3176@sortiz-mobl> (raw)
In-Reply-To: <1354201468-9219-1-git-send-email-p.zabel@pengutronix.de>
Hi Philipp,
On Thu, Nov 29, 2012 at 04:04:28PM +0100, Philipp Zabel wrote:
> The patch "mfd: da9052-core: Use regmap_irq_get_virq() and fix the probe"
> replaces the irq_base with the da9052_map_irq function but doesn't
> update the irq_base parameter to the mfd_add_devices call.
> This causes child devices to try and request IRQs with just the internal
> offset number.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> drivers/mfd/da9052-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, although I'd like to get Fabio's ACK on it.
I think this is a problem he should have seen, although he could have missed
it since the original patch is a fairly old one and there have been some MFD
API changes in between.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-11-30 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 15:04 [PATCH] mfd: da9052-core: Fix interrupts reported to mfd child devices Philipp Zabel
2012-11-30 11:04 ` Samuel Ortiz [this message]
2012-11-30 11:16 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130110438.GO3176@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=fabio.estevam@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.