All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Marowsky-Bree <lmb@suse.com>
To: device-mapper development <dm-devel@redhat.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [dm-devel] [PATCH 2/3] dm raid1: add interface to set resync speed
Date: Fri, 30 Nov 2012 12:39:28 +0100	[thread overview]
Message-ID: <20121130113928.GO29064@suse.de> (raw)
In-Reply-To: <1353565673-4233-3-git-send-email-gzhao@suse.com>

On 2012-11-22T14:27:52, Guangliang Zhao <gzhao@suse.com> wrote:

Hi Guangliang,

thanks for adding this. I think this approach is a good direction to
take, just one feedback:

> Add ioctl to control resync speed, userspace tool
> is dmsetup message, message format is:
> 	dmsetup message $device 0 "set $speed"
> e.g.
> 	dmsetup message /dev/dm-2 "set 12345"

I think this should be "set-max-resync-rate" or something; "set" is very
generic and not very extensible going forward, should the need arise.

Regards,
    Lars

-- 
Architect Storage/HA
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 21284 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

  reply	other threads:[~2012-11-30 11:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-22  6:27 [PATCH 0/3] add resync speed control for dm-raid1 Guangliang Zhao
2012-11-22  6:27 ` [PATCH 1/3] dm raid1: " Guangliang Zhao
2012-11-22  6:27 ` [PATCH 2/3] dm raid1: add interface to set resync speed Guangliang Zhao
2012-11-30 11:39   ` Lars Marowsky-Bree [this message]
2012-12-03  9:12     ` [dm-devel] " Guangliang Zhao
2012-11-22  6:27 ` [PATCH 3/3] dm raid1: add interface to get " Guangliang Zhao
2012-12-10  2:21 ` [dm-devel] [PATCH 0/3] add resync speed control for dm-raid1 NeilBrown
2012-12-10 12:27   ` Guangliang Zhao
2012-12-11  8:56   ` Lars Marowsky-Bree
2012-12-11  8:56     ` [dm-devel] " Lars Marowsky-Bree

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121130113928.GO29064@suse.de \
    --to=lmb@suse.com \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.