Re: [PATCH] hfsplus: rework processing of hfs_btree_write() returned error

[Andrew Morton <akpm@linux-foundation.org>]

On Fri, 30 Nov 2012 14:49:26 +0400
Vyacheslav Dubeyko <slava@dubeyko.com> wrote:

> Hi,
> 
> The patch adds in hfs_btree_write() returning of -EIO in the case of failing of b-tree's node searching.
> 
> With the best regards,
> Vyacheslav Dubeyko.
> --
> From: Vyacheslav Dubeyko <slava@dubeyko.com>
> Subject: [PATCH] hfsplus: rework processing of hfs_btree_write() returned error
> 
> The patch adds in hfs_btree_write() returning of -EIO in the case of failing of b-tree's node searching. It is added also logic of processing errors of hfs_btree_write() in hfsplus_system_write_inode() with message about b-tree writing failure.
> 
> Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>

We don't need two changelogs for each patch ;) The patch's formal
changelog text should be sufficient.

> fs/hfsplus/btree.c      |    5 +++--
> fs/hfsplus/hfsplus_fs.h |    2 +-
> fs/hfsplus/super.c      |   12 ++++++++++--
> 3 files changed, 14 insertions(+), 5 deletions(-)

I modified a couple of things, please review:

From: Andrew Morton <akpm@linux-foundation.org>
Subject: hfsplus-rework-processing-of-hfs_btree_write-returned-error-fix

reduce scope of `err', print errno on error

Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Hin-Tak Leung <htl10@users.sourceforge.net>
Cc: Vyacheslav Dubeyko <slava@dubeyko.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/hfsplus/super.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/fs/hfsplus/super.c~hfsplus-rework-processing-of-hfs_btree_write-returned-error-fix
+++ a/fs/hfsplus/super.c
@@ -100,7 +100,6 @@ static int hfsplus_system_write_inode(st
 	struct hfsplus_vh *vhdr = sbi->s_vhdr;
 	struct hfsplus_fork_raw *fork;
 	struct hfs_btree *tree = NULL;
-	int err;
 
 	switch (inode->i_ino) {
 	case HFSPLUS_EXT_CNID:
@@ -131,9 +130,10 @@ static int hfsplus_system_write_inode(st
 	}
 	hfsplus_inode_write_fork(inode, fork);
 	if (tree) {
-		err = hfs_btree_write(tree);
+		int err = hfs_btree_write(tree);
 		if (err) {
-			printk(KERN_ERR "hfs: unable to write b-tree\n");
+			printk(KERN_ERR "hfs: unable to write b-tree: %d\n",
+				err);
 			dprint(DBG_INODE, "hfsplus_system_write_inode: %lu\n",
 				inode->i_ino);
 			return err;
_