All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Myers <bpm@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/4] xfs: fix sparse reported log CRC endian issue
Date: Fri, 30 Nov 2012 10:04:32 -0600	[thread overview]
Message-ID: <20121130160432.GR24185@sgi.com> (raw)
In-Reply-To: <20121130160330.GA5667@infradead.org>

Hey Christoph,

On Fri, Nov 30, 2012 at 11:03:30AM -0500, Christoph Hellwig wrote:
> On Thu, Nov 29, 2012 at 02:32:50PM -0600, Ben Myers wrote:
> > This seems reasonable to me, and the patch looks fine.  Christoph, do have any
> > further objection?
> 
> No, although adding the explanation as a comment would be useful.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Cool.  I'll add it in then.

Thanks,
	Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-11-30 16:02 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28  2:00 [PATCH 0/4] xfs: patch queue for 3.8 Dave Chinner
2012-11-28  2:01 ` [PATCH 1/4] xfs: fix direct IO nested transaction deadlock Dave Chinner
2012-11-28 13:27   ` Christoph Hellwig
2012-11-28  2:01 ` [PATCH 2/4] xfs: byte range granularity for XFS_IOC_ZERO_RANGE Dave Chinner
2012-11-28 13:33   ` Christoph Hellwig
2012-11-29  0:06     ` Christoph Hellwig
2012-11-29  1:54       ` Dave Chinner
2012-11-29  4:18         ` Dave Chinner
2012-11-29  4:26   ` [PATCH 2/4 V2] " Dave Chinner
2012-11-29 18:19     ` Andrew Dahl
2012-11-30 16:07     ` Christoph Hellwig
2012-11-28  2:01 ` [PATCH 3/4] xfs: fix stray dquot unlock when reclaiming dquots Dave Chinner
2012-11-28 13:28   ` Christoph Hellwig
2012-11-28  2:01 ` [PATCH 4/4] xfs: fix sparse reported log CRC endian issue Dave Chinner
2012-11-28 13:30   ` Christoph Hellwig
2012-11-28 21:31     ` Dave Chinner
2012-11-29 20:32       ` Ben Myers
2012-11-30 16:03         ` Christoph Hellwig
2012-11-30 16:04           ` Ben Myers [this message]
2012-12-03 18:18             ` Ben Myers
2012-11-29 22:29   ` Mark Tinguely
2012-11-29 21:22 ` [PATCH 0/4] xfs: patch queue for 3.8 Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121130160432.GR24185@sgi.com \
    --to=bpm@sgi.com \
    --cc=hch@infradead.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.