Re: [PATCH v2 2/2] New driver: Xillybus generic interface for FPGA (programmable logic)

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Nov 30, 2012 at 05:27:37PM +0200, Eli Billauer wrote:
> I made changes in the code as a response to almost all your comments
> to my best understanding.
> 
> I also sent a separate mail responding to a couple of issues, which
> seems not have reached you.

I now see it, sorry for the grumpy pre-coffee response I made earlier.

> But to put it short:
> 
> * The pci_ids: I wasn't sure if I should remove only my own product
> ID or all the vendor IDs, and this is clear now.

Good.

> * As for the documentation, I don't quite understand what I should
> add. There's a rather extensive documentation for download at the
> site. The docs for the host side mostly instruct common UNIX
> programming techniques: The device files are just data pipes to
> FIFOs in the FPGA, behaving like one would expect.

You need to document the user/kernel API that you have now created for
this driver, either in the Documentation directory, or in the very
least, the driver submission changelog entry.  Otherwise we don't know
where to look, nor if those docs are even correct anymore.

> * As for the special class issue: When Xillybus is used, the whole
> system's mission is usually around it (e.g. it's a computer doing
> data acquisition through the Xillybus pipes). So giving it a high
> profile makes sense, I believe. Besides, a dozen of device files are
> not rare. Needless to say, I'm not going to insist on this.

Good, please use misc device, for the reasons I suggested in my other
email.

> Other than that, it's all changes in the code. It's a major change
> there.

I don't understand what these sentances mean.

greg k-h