All of lore.kernel.org
 help / color / mirror / Atom feed
From: mdroth <mdroth@linux.vnet.ibm.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4)
Date: Fri, 30 Nov 2012 12:22:08 -0600	[thread overview]
Message-ID: <20121130182208.GP8690@vm> (raw)
In-Reply-To: <1354021324-31561-1-git-send-email-lcapitulino@redhat.com>

On Tue, Nov 27, 2012 at 11:01:54AM -0200, Luiz Capitulino wrote:
> This series revamps qemu-ga error messages by:
> 
>  - Propagating errors down to functions that generate errors
>  - Fixing UndefinedErrors
>  - Getting rid of sprint() + error_set()
>  - Other small fixes
> 
> Only the POSIX port is covered in this series, win32 is left to another day.

Thanks, applied to qga branch:

https://github.com/mdroth/qemu/commits/qga

with a small formatting fix for 01/10

> 
> Luiz Capitulino (10):
>   qemu-ga: guest_file_handle_find(): take an Error argument
>   qemu-ga: qmp_guest_file_close(): fix fclose() error check
>   qemu-ga: qmp_guest_file_*: improve error reporting
>   qemu-ga: qmp_guest_shutdown(): improve error reporting
>   qemu-ga: build_fs_mount_list(): take an Error argument
>   qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set()
>   qemu-ga: qmp_guest_fstrim(): get rid of sprintf() + error_set()
>   qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() +
>     error_set()
>   qemu-ga: bios_supports_mode(): improve error reporting
>   qemu-ga: guest_suspend(): improve error reporting
> 
>  qga/commands-posix.c | 244 ++++++++++++++++++++++++++++-----------------------
>  1 file changed, 134 insertions(+), 110 deletions(-)
> 
> -- 
> 1.8.0
> 

      parent reply	other threads:[~2012-11-30 18:25 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 13:01 [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4) Luiz Capitulino
2012-11-27 13:01 ` [Qemu-devel] [PATCH 01/10] qemu-ga: guest_file_handle_find(): take an Error argument Luiz Capitulino
2012-11-28 17:01   ` mdroth
2012-11-27 13:01 ` [Qemu-devel] [PATCH 02/10] qemu-ga: qmp_guest_file_close(): fix fclose() error check Luiz Capitulino
2012-11-28 17:02   ` mdroth
2012-11-27 13:01 ` [Qemu-devel] [PATCH 03/10] qemu-ga: qmp_guest_file_*: improve error reporting Luiz Capitulino
2012-11-28 17:54   ` mdroth
2012-11-28 19:31     ` Luiz Capitulino
2012-11-28 21:26       ` Eric Blake
2012-11-28 22:17         ` mdroth
2012-11-29 12:00           ` Luiz Capitulino
2012-11-27 13:01 ` [Qemu-devel] [PATCH 04/10] qemu-ga: qmp_guest_shutdown(): " Luiz Capitulino
2012-11-28 19:27   ` mdroth
2012-11-27 13:01 ` [Qemu-devel] [PATCH 05/10] qemu-ga: build_fs_mount_list(): take an Error argument Luiz Capitulino
2012-11-28 19:34   ` mdroth
2012-11-29 17:29   ` [Qemu-devel] [PATCH v2 " Luiz Capitulino
2012-11-27 13:02 ` [Qemu-devel] [PATCH 06/10] qemu-ga: qmp_guest_fsfreeze_*(): get rid of sprintf() + error_set() Luiz Capitulino
2012-11-28 19:40   ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 07/10] qemu-ga: qmp_guest_fstrim(): " Luiz Capitulino
2012-11-28 19:41   ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 08/10] qemu-ga: qmp_guest_network_get_interfaces(): get rid of snprintf() " Luiz Capitulino
2012-11-28 19:43   ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 09/10] qemu-ga: bios_supports_mode(): improve error reporting Luiz Capitulino
2012-11-28 19:48   ` mdroth
2012-11-27 13:02 ` [Qemu-devel] [PATCH 10/10] qemu-ga: guest_suspend(): " Luiz Capitulino
2012-11-28 19:49   ` mdroth
2012-11-28 20:04 ` [Qemu-devel] [PATCH 00/10] qemu-ga: revamp error messages (for 1.4) mdroth
2012-11-28 20:12   ` mdroth
2012-12-12  1:03   ` Eric Blake
2012-11-30 18:22 ` mdroth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121130182208.GP8690@vm \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.