From: Florian Westphal <fw@strlen.de>
To: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] Handle routing changes for the MASQUERADE target
Date: Fri, 30 Nov 2012 22:40:32 +0100 [thread overview]
Message-ID: <20121130214032.GF31969@breakpoint.cc> (raw)
In-Reply-To: <alpine.DEB.2.00.1211302222190.16257@blackhole.kfki.hu>
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu> wrote:
> > > + if (nat->masq_index && hooknum == NF_INET_POST_ROUTING &&
> > > + CTINFO2DIR(ctinfo) == IP_CT_DIR_ORIGINAL &&
> > > + nat->masq_index != out->ifindex) {
> > > + /* Outgoing interface changed, destroy conntrack. */
> > > + nf_ct_kill_acct(cf, ctinfo, skb);
> > > + nf_ct_put(ct);
> >
> > Hmm. Is the nf_ct_put() correct?
> > nf_ct_kill invokes death_by_timeout(), which also puts ct.
>
> nf_nat_ipv[46]_fn starts with "nf_ct_get", so that must be released.
nf_ct_get() does not increase refcount :)
Regards,
Florian
next prev parent reply other threads:[~2012-11-30 21:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 20:51 [PATCH] Handle routing changes for the MASQUERADE target Jozsef Kadlecsik
2012-11-30 21:11 ` Florian Westphal
2012-11-30 21:27 ` Jozsef Kadlecsik
2012-11-30 21:40 ` Florian Westphal [this message]
2012-11-30 22:28 ` Jozsef Kadlecsik
2012-11-30 22:37 ` [PATCH] Handle routing changes in MASQUERADE target, v4 Jozsef Kadlecsik
2012-12-03 18:28 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121130214032.GF31969@breakpoint.cc \
--to=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.