From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 15/16] drm/i915: Use a slab for object allocation Date: Fri, 30 Nov 2012 23:45:04 +0100 Message-ID: <20121130224504.GD4384@phenom.ffwll.local> References: <1352979151-9934-1-git-send-email-chris@chris-wilson.co.uk> <1352979151-9934-16-git-send-email-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 386A6E67DC for ; Fri, 30 Nov 2012 14:43:42 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so593037eek.36 for ; Fri, 30 Nov 2012 14:43:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <1352979151-9934-16-git-send-email-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Nov 15, 2012 at 11:32:30AM +0000, Chris Wilson wrote: > The primary purpose of this was to debug some use-after-free memory > corruption that was causing an OOPS inside drm/i915. As it turned out > the corruption was being caused elsewhere and i915.ko as a major user of > many objects was being hit hardest. > > Indeed as we do frequent the generic kmalloc caches, dedicating one to > ourselves (or at least naming one for us depending upon the core) aids > debugging our own slab usage. > > Signed-off-by: Chris Wilson > Reviewed-by: Jesse Barnes > Reviewed-by: Ben Widawsky Slurped in thus far, safe for the three patches I've already mentioned in the previous reply. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch