From: Zheng Liu <gnehzuil.liu@gmail.com>
To: zwu.kernel@gmail.com
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu,
linux-kernel@vger.kernel.org,
Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: remove some unused code lines
Date: Sun, 2 Dec 2012 20:27:26 +0800 [thread overview]
Message-ID: <20121202122726.GA14852@gmail.com> (raw)
In-Reply-To: <1354183200-8628-1-git-send-email-zwu.kernel@gmail.com>
On Thu, Nov 29, 2012 at 06:00:00PM +0800, zwu.kernel@gmail.com wrote:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Please write a commit log to describe this patch, even though it is
quite simple and straightfoward
Otherwise, it looks good to me.
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
Regards,
- Zheng
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> fs/ext4/extents.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index 7011ac9..43ec639 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -2156,7 +2156,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
> struct ext4_extent *ex)
> {
> struct ext4_ext_cache *cex;
> - struct ext4_sb_info *sbi;
> int ret = 0;
>
> /*
> @@ -2164,7 +2163,6 @@ ext4_ext_in_cache(struct inode *inode, ext4_lblk_t block,
> */
> spin_lock(&EXT4_I(inode)->i_block_reservation_lock);
> cex = &EXT4_I(inode)->i_cached_extent;
> - sbi = EXT4_SB(inode->i_sb);
>
> /* has cache valid data? */
> if (cex->ec_len == 0)
> --
> 1.7.6.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-12-02 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 10:00 [PATCH] ext4: remove some unused code lines zwu.kernel
2012-12-02 12:27 ` Zheng Liu [this message]
2012-12-03 2:11 ` Zhi Yong Wu
2012-12-07 0:06 ` Theodore Ts'o
-- strict thread matches above, loose matches on Subject: below --
2012-12-03 2:25 zwu.kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121202122726.GA14852@gmail.com \
--to=gnehzuil.liu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.