From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH v2] KVM: x86: Fix uninitialized return code
Date: Sun, 2 Dec 2012 17:38:57 +0200
Message-ID: <20121202153857.GH8731@redhat.com>
References: <50BB2657.9010104@web.de>
 <50BB279E.1090105@web.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>,
	Guo Chao <yan@linux.vnet.ibm.com>
To: Jan Kiszka <jan.kiszka@web.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:29291 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751448Ab2LBPjB (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 2 Dec 2012 10:39:01 -0500
Content-Disposition: inline
In-Reply-To: <50BB279E.1090105@web.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Dec 02, 2012 at 11:04:14AM +0100, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This is a regression caused by 18595411a7.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Applied, thanks.

> ---
> 
> Sorry, copy&pasted wrong error code.
> 
>  arch/x86/kvm/x86.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index b0b8abe..3bdaf29 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3006,6 +3006,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
>  		break;
>  	}
>  	case KVM_SET_LAPIC: {
> +		r = -EINVAL;
>  		if (!vcpu->arch.apic)
>  			goto out;
>  		u.lapic = memdup_user(argp, sizeof(*u.lapic));
> -- 
> 1.7.3.4

--
			Gleb.