From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: GShark Jeong <gshark.jeong@gmail.com>
Cc: Liam Gridwood <lrg@ti.com>, Daniel Jeong <daniel.jeong@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] regulator: new driver for LP8755
Date: Mon, 3 Dec 2012 16:27:42 +0900 [thread overview]
Message-ID: <20121203072741.GC9848@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAPqQCJW6TLhxRkOdw6JVe1qkepDDKdt+wagAgd5VCCsE3y6Qog@mail.gmail.com>
On Mon, Dec 03, 2012 at 04:24:43PM +0900, GShark Jeong wrote:
> 2012/12/3 Mark Brown <broonie@opensource.wolfsonmicro.com>
> > On Mon, Dec 03, 2012 at 01:44:24PM +0900, Daniel Jeong wrote:
> > > + if (ret < 0)
> > > + goto out_i2c_error;
> > > + dev_info(pchip->dev, "lp8755 : chip ID is 0x%x\n", regval);
> > This isn't actually checking anything except the I/O. Can the chip ID
> > really vary?
> My configurations are already programmed in otp memory of chip as default
> values.
> So this comment for to others who are using different initial values with
> default data.
> I will drop it.
It seems like a better fix would be to add a check for the ID and fail
if the OTP value doesn't match, that way the driver won't try to run on
unsupported hardware.
next prev parent reply other threads:[~2012-12-03 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 4:44 [PATCH 0/1] regulator: new driver for LP8755 Daniel Jeong
2012-12-03 4:44 ` [PATCH 1/1] " Daniel Jeong
2012-12-03 6:25 ` Wanlong Gao
2012-12-03 6:36 ` Mark Brown
[not found] ` <CAPqQCJW6TLhxRkOdw6JVe1qkepDDKdt+wagAgd5VCCsE3y6Qog@mail.gmail.com>
2012-12-03 7:27 ` Mark Brown [this message]
2012-12-03 6:11 ` [PATCH 0/1] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203072741.GC9848@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=daniel.jeong@ti.com \
--cc=gshark.jeong@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.