All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Cong Ding <dinggnu@gmail.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools:virtio: fix compilation warning
Date: Mon, 3 Dec 2012 13:01:06 +0200	[thread overview]
Message-ID: <20121203110106.GB26167@redhat.com> (raw)
In-Reply-To: <1354530294-10178-1-git-send-email-dinggnu@gmail.com>

On Mon, Dec 03, 2012 at 10:24:54AM +0000, Cong Ding wrote:
> We do not allow old-style function definition.  Always spell foo(void) if
> a function does not take any parameters.
> 
> Signed-off-by: Cong Ding <dinggnu@gmail.com>

Thanks, applied.

> ---
>  tools/virtio/virtio_test.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/virtio/virtio_test.c b/tools/virtio/virtio_test.c
> index e626fa5..6d25dcd 100644
> --- a/tools/virtio/virtio_test.c
> +++ b/tools/virtio/virtio_test.c
> @@ -232,7 +232,7 @@ const struct option longopts[] = {
>  	}
>  };
>  
> -static void help()
> +static void help(void)
>  {
>  	fprintf(stderr, "Usage: virtio_test [--help]"
>  		" [--no-indirect]"
> -- 
> 1.7.4.5

      reply	other threads:[~2012-12-03 10:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-03 10:24 [PATCH] tools:virtio: fix compilation warning Cong Ding
2012-12-03 11:01 ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121203110106.GB26167@redhat.com \
    --to=mst@redhat.com \
    --cc=dinggnu@gmail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.