From: Cong Ding <dinggnu@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Adam Buchbinder" <adam.buchbinder@gmail.com>,
"Jesper Juhl" <jj@chaosbits.net>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging: fix compilation warning
Date: Mon, 3 Dec 2012 11:04:29 +0000 [thread overview]
Message-ID: <20121203110428.GA22681@gmail.com> (raw)
In-Reply-To: <20121203105609.GE6568@mwanda>
On Mon, Dec 03, 2012 at 01:56:09PM +0300, Dan Carpenter wrote:
> On Mon, Dec 03, 2012 at 10:34:08AM +0000, Cong Ding wrote:
> > We do not allow old-style function definition. Always spell foo(void) if
> > a function does not take any parameters.
> >
>
> You should be working against linux-next. This driver has been
> deleted in linux-next.
>
> The subject should have been:
> [PATCH] Staging: telephony/ixj: fix sparse warning
> or something like that. "drivers" is not useful. And Staging by
> itself is too broad.
>
> I think it's a Sparse warning, not a compile warning? Copy and
> paste the warning into the commit message.
sure, thanks for the suggestions.
- cong
>
> Anyway, since this was deleted it doesn't matter.
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2012-12-03 11:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 10:34 [PATCH] drivers:staging: fix compilation warning Cong Ding
2012-12-03 10:56 ` Dan Carpenter
2012-12-03 11:04 ` Cong Ding [this message]
2012-12-03 15:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203110428.GA22681@gmail.com \
--to=dinggnu@gmail.com \
--cc=adam.buchbinder@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.