From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] xtensa: add config option to enable longcalls option
Date: Mon, 3 Dec 2012 14:09:12 +0100 [thread overview]
Message-ID: <20121203140912.1e09f0ea@skate> (raw)
In-Reply-To: <50bc6a34.45e8440a.493d.4091@mx.google.com>
Dear Chris Zankel,
On Mon, 3 Dec 2012 00:58:46 -0800, Chris Zankel wrote:
> The longcalls option allows calls across a greater range of addresses.
>
> This option should be used when call targets can potentially be
> out of range. It may degrade both code size and performance, but
> the linker can generally optimize away the unnecessary overhead
> when a call ends up within range.
>
> This option is enabled by default.
>
> Signed-off-by: Chris Zankel <chris@zankel.net>
> ---
> arch/Config.in.xtensa | 17 +++++++++++++++++
> package/Makefile.in | 6 ++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/arch/Config.in.xtensa b/arch/Config.in.xtensa
> index 60c03f5..a979108 100644
> --- a/arch/Config.in.xtensa
> +++ b/arch/Config.in.xtensa
> @@ -35,3 +35,20 @@ config BR2_XTENSA_OVERLAY_DIR
>
> config BR2_ARCH
> default "xtensa" if BR2_xtensa
> +
> +menu "Target build options"
> +
> +config BR2_XTENSA_LONGCALLS
> + bool "Enable longcalls option"
> + default y
> + help
> + Enable or disable transformation of call instructions to allow
> + calls across a greater range of addresses.
> + This option should be used when call targets can potentially be
> + out of range. It may degrade both code size and performance, but
> + the linker can generally optimize away the unnecessary overhead
> + when a call ends up within range.
> +
> + Should be enabled by default.
> +
> +endmenu
Do we really want that as a configurable option? Isn't it possible
instead to always generate longcalls, or to fix this on a per-package
basis, when needed?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-12-03 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 8:58 [Buildroot] [PATCH v2] xtensa: add config option to enable longcalls option Chris Zankel
2012-12-03 13:09 ` Thomas Petazzoni [this message]
2012-12-04 8:36 ` czankel
2012-12-04 9:17 ` Thomas Petazzoni
2012-12-04 20:13 ` Peter Korsgaard
2012-12-04 20:40 ` Chris Zankel
2012-12-04 21:39 ` Thomas Petazzoni
2012-12-04 21:55 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121203140912.1e09f0ea@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.