From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 3/5] serial: 8250_dw: Map IO memory
Date: Tue, 4 Dec 2012 10:17:13 +0200 [thread overview]
Message-ID: <20121204081713.GA8071@xps8300> (raw)
In-Reply-To: <20121203154014.GA20140@page>
Hi Jamie,
On Mon, Dec 03, 2012 at 03:40:14PM +0000, Jamie Iles wrote:
> > + uart.port.membase = ioremap(regs->start, regs->end - regs->start);
>
> Doesn't this have an off-by-one error?
True.
> + uart.port.membase = ioremap(regs->start, resource_size(regs));
>
> instead?
Yes, I'll fix this. Thanks!
--
heikki
next prev parent reply other threads:[~2012-12-04 8:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 11:17 [PATCHv2 0/5] serial: 8250: 8250_dw changes and dynamic capabilities Heikki Krogerus
2012-12-03 11:17 ` [PATCHv2 1/5] serial: 8250: Allow drivers to deliver capabilities Heikki Krogerus
2012-12-03 11:17 ` [PATCHv2 2/5] serial: 8250_dw: Don't use UPF_FIXED_TYPE Heikki Krogerus
2012-12-03 11:17 ` [PATCHv2 3/5] serial: 8250_dw: Map IO memory Heikki Krogerus
2012-12-03 11:47 ` Alan Cox
2012-12-03 15:40 ` Jamie Iles
2012-12-04 8:17 ` Heikki Krogerus [this message]
2012-12-04 15:21 ` [PATCHv3 " Heikki Krogerus
2012-12-04 17:02 ` Jamie Iles
2012-12-03 11:17 ` [PATCHv2 4/5] serial: 8250_dw: Move device tree code to separate function Heikki Krogerus
2012-12-03 11:17 ` [PATCHv2 5/5] serial: 8250_dw: Set FIFO size dynamically Heikki Krogerus
2012-12-03 15:43 ` [PATCHv2 0/5] serial: 8250: 8250_dw changes and dynamic capabilities Jamie Iles
2013-01-09 9:22 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204081713.GA8071@xps8300 \
--to=heikki.krogerus@linux.intel.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.