From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tao Ma <tm@tao.ma>
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [ext4:dev 40/60] fs/ext4/inode.c:1953 __ext4_journalled_writepage() error: potential NULL dereference 'page_bufs'.
Date: Tue, 4 Dec 2012 16:56:02 +0300 [thread overview]
Message-ID: <20121204135602.GE22569@mwanda> (raw)
In-Reply-To: <1354627545-2792-1-git-send-email-tm@tao.ma>
On Tue, Dec 04, 2012 at 09:25:45PM +0800, Tao Ma wrote:
> Hi Dan,
> Thanks for the report. Can you check whether this patch
> works for you?
>
It looks good.
Like I mentioned before Smatch doesn't understand
ext4_has_inline_data() so it still complains later on in the
function. But it's now obvious to a human reader that there won't
be a NULL dereference.
regards,
dan carpenter
next prev parent reply other threads:[~2012-12-04 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 11:10 [ext4:dev 40/60] fs/ext4/inode.c:1953 __ext4_journalled_writepage() error: potential NULL dereference 'page_bufs' Dan Carpenter
2012-12-04 13:25 ` Tao Ma
2012-12-04 13:56 ` Dan Carpenter [this message]
2012-12-05 5:41 ` Theodore Ts'o
2012-12-05 8:31 ` Dan Carpenter
2012-12-05 16:25 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121204135602.GE22569@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.