From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/10] gmbus/dp aux irqfication Date: Wed, 5 Dec 2012 11:59:59 +0100 Message-ID: <20121205105959.GI11556@phenom.ffwll.local> References: <1354366429-2324-1-git-send-email-daniel.vetter@ffwll.ch> <1354637088.746.3.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id B1F81E5D02 for ; Wed, 5 Dec 2012 02:58:31 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so2847126eek.36 for ; Wed, 05 Dec 2012 02:58:30 -0800 (PST) Content-Disposition: inline In-Reply-To: <1354637088.746.3.camel@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Imre Deak Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Tue, Dec 04, 2012 at 06:04:48PM +0200, Imre Deak wrote: > On Sat, 2012-12-01 at 13:53 +0100, Daniel Vetter wrote: > > Hi all, > > > > Irq-drive gmbus/dp aux transfer, simply because we can (and at least in the case > > of gmbus, it's quite a bit faster than the msleep(1) loop - we now reliably > > transfer at full wire speed insteaf of sometimes 2-3x slower). > > > > Compared to the older version I've floated on irc way back and which Chris has > > carried around in his wip branchs (and inflicted upon tons of unsuspecting bug > > reporters) there are a few differences: > > - handle the hpd vs. setup race - even the current code enables hpd processing > > before the fbdev is set up, which is too early. > > - fix the gen4 gmbus support, was totally busted. > > - tested on hsw (although all the relevant bits are a 100% match with cpt/ivb). > > - disable dp aux irq on vlv - too complicated to get at the docs (moved again, > > old access revoked) and I don't have the hw. > > > > While reviewing this patch series I've also noticed two small things in the irq > > handling code in general, patches for that at the beginning of the series. > > > > Comment&review highgly welcome. > > Looks good to me. On the series: > Reviewed-by: Imre Deak Thanks for the review, series merged. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch