From: Johan Hedberg <johan.hedberg@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: "Frédéric Danis" <frederic.danis@linux.intel.com>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] hciconfig: Remove putkey command
Date: Wed, 5 Dec 2012 13:26:14 +0200 [thread overview]
Message-ID: <20121205112614.GA6412@x220.ger.corp.intel.com> (raw)
In-Reply-To: <1354705606.1815.6.camel@aeonflux>
Hi,
On Wed, Dec 05, 2012, Marcel Holtmann wrote:
> > tools/hciconfig.c | 64 -----------------------------------------------------
> > 1 file changed, 64 deletions(-)
>
> that command does have a manpage entry.
And I'd appreciate an explanation in the commit message body for *why*
the command is removed. It's not like it's going to be obvious for
anybody looking at the commit history, at least not a more than a year
from now.
Johan
next prev parent reply other threads:[~2012-12-05 11:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-05 10:20 [PATCH] hciconfig: Retrieve linkey from device info file Frédéric Danis
2012-12-05 10:33 ` Marcel Holtmann
2012-12-05 11:02 ` [PATCH v2] hciconfig: Remove putkey command Frédéric Danis
2012-12-05 11:06 ` Marcel Holtmann
2012-12-05 11:26 ` Johan Hedberg [this message]
2012-12-05 11:43 ` [PATCH v3] " Frédéric Danis
2012-12-05 15:25 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121205112614.GA6412@x220.ger.corp.intel.com \
--to=johan.hedberg@gmail.com \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.