From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 1/1] drm/i915: Remove duplicate and unused register #defines in i915_reg.h Date: Wed, 5 Dec 2012 16:04:19 +0100 Message-ID: <20121205150419.GL11556@phenom.ffwll.local> References: <1354718237-27348-1-git-send-email-dexuan.cui@intel.com> <275ffc$7nc3rr@fmsmga002.fm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id E2A49E6543 for ; Wed, 5 Dec 2012 07:02:51 -0800 (PST) Received: by mail-ee0-f49.google.com with SMTP id c4so3006282eek.36 for ; Wed, 05 Dec 2012 07:02:51 -0800 (PST) Content-Disposition: inline In-Reply-To: <275ffc$7nc3rr@fmsmga002.fm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Dec 05, 2012 at 02:50:04PM +0000, Chris Wilson wrote: > On Wed, 5 Dec 2012 22:37:17 +0800, Dexuan Cui wrote: > > TRANS_DP_VIDEO_AUDIO is not used at all. > > Now you are just opening a can of worms, as none of them are actually > used other than as documentation. > > > The other 3 has duplicated #defines. > > > > Signed-off-by: Dexuan Cui > Reviewed-by: Chris Wilson Queued for -next, thanks for the patch. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch