From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH V5 2/2] mfd: stmpe: Update DT support in stmpe driver Date: Thu, 6 Dec 2012 11:33:51 +0000 Message-ID: <20121206113351.GS2718@gmail.com> References: <20121205224203.691153E0E22@localhost> <20121206095019.GN2718@gmail.com> <20121206101131.GP2718@gmail.com> <20121206103515.GQ2718@gmail.com> <20121206111252.GR2718@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Viresh Kumar Cc: rabin.vincent-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org, Samuel Ortiz , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, spear-devel-nkJGhpqTU55BDgjK7y7TUQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, shiraz.hashim-qxv4g6HH51o@public.gmane.org List-Id: devicetree@vger.kernel.org T24gVGh1LCAwNiBEZWMgMjAxMiwgVmlyZXNoIEt1bWFyIHdyb3RlOgoKPiBPbiA2IERlY2VtYmVy IDIwMTIgMTY6NDIsIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+IHdyb3RlOgo+ID4g SSB0aG91Z2h0IHdlJ2QgYmUgb3ZlciB0aGlzPyBUaGUgJ0lEJyB3aWxsIGJlIHJlcHJlc2VudGVk IGJ5IHRoZQo+ID4gYWRkcmVzcyBvZiB0aGUgY2hpcCBpLmUuIHN0bXBlMTYwMUA0MCwgd2hlcmUg JzQwJyB3aWxsIGJlCj4gPiBkaXN0aW5ndWlzaGluZyBmYWN0b3I/Cj4gCj4gSSBoYXZlbid0IHRl c3RlZCBpdCBidXQgaSB0aG91Z2h0IHdlIGFyZSBnZXR0aW5nIGkyYyBkZXZpY2UgbmFtZSBmcm9t Cj4gbW9kYWxpYXMoKSBmbiBydW5uaW5nIG9uICJzdCxzdG1wZTE2MDEiIGFuZCBzbyB3b3VsZCBn aXZlIHVzICJzdG1wZTE2MDEiLgo+IAo+IE5vdywgaSB3ZW50IGJhY2sgdG8geW91ciBlYXJsaWVy IG1haWwgYW5kIGNoZWNrZWQgZGV2aWNlIG5hbWU6Cj4gc3RtcGUtaTJjIDAtMDA0MDogc3RtcGUx NjAxIGRldGVjdGVkLCBjaGlwIGlkOiAweDIxMgo+IAo+IEl0IGNhbWUgZnJvbSBEVCA6KQo+IAo+ IFNvLCBwcm9iYWJseSBubyBtb3JlIGlzc3VlcyBvZiBpZCdzLiBXaWxsIHJlc2VuZCBteSBwYXRj aCwgYWZ0ZXIgZ2V0dGluZwo+IHJpZCBvZiB0YWJsZXMuCgpOb3cgd2UncmUgdGFsa2luZyEKCi0t IApMZWUgSm9uZXMKTGluYXJvIFNULUVyaWNzc29uIExhbmRpbmcgVGVhbSBMZWFkCkxpbmFyby5v cmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpGb2xsb3cgTGluYXJvOiBG YWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmRldmljZXRyZWUtZGlzY3VzcyBtYWlsaW5nIGxpc3QKZGV2aWNldHJl ZS1kaXNjdXNzQGxpc3RzLm96bGFicy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3Rp bmZvL2RldmljZXRyZWUtZGlzY3Vzcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754978Ab2LFLeA (ORCPT ); Thu, 6 Dec 2012 06:34:00 -0500 Received: from mail-bk0-f46.google.com ([209.85.214.46]:49275 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423283Ab2LFLd5 (ORCPT ); Thu, 6 Dec 2012 06:33:57 -0500 Date: Thu, 6 Dec 2012 11:33:51 +0000 From: Lee Jones To: Viresh Kumar Cc: Grant Likely , Samuel Ortiz , rabin.vincent@stericsson.com, shiraz.hashim@st.com, devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org, spear-devel@list.st.com, linus.walleij@linaro.org, Vipul Kumar Samar Subject: Re: [PATCH V5 2/2] mfd: stmpe: Update DT support in stmpe driver Message-ID: <20121206113351.GS2718@gmail.com> References: <20121205224203.691153E0E22@localhost> <20121206095019.GN2718@gmail.com> <20121206101131.GP2718@gmail.com> <20121206103515.GQ2718@gmail.com> <20121206111252.GR2718@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Dec 2012, Viresh Kumar wrote: > On 6 December 2012 16:42, Lee Jones wrote: > > I thought we'd be over this? The 'ID' will be represented by the > > address of the chip i.e. stmpe1601@40, where '40' will be > > distinguishing factor? > > I haven't tested it but i thought we are getting i2c device name from > modalias() fn running on "st,stmpe1601" and so would give us "stmpe1601". > > Now, i went back to your earlier mail and checked device name: > stmpe-i2c 0-0040: stmpe1601 detected, chip id: 0x212 > > It came from DT :) > > So, probably no more issues of id's. Will resend my patch, after getting > rid of tables. Now we're talking! -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog