Re: [PATCH] SPI: SSP SPI Controller driver

[Alan Cox <alan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

> I think I've asked this question before, but I can't remember if I've
> gotten an answer. How is this different from the designware spi
> controller that is already in the tree for medfield and moorestown MID
> platforms? (drivers/spi/spi-dw-mid.c).

Different devices.


> ... Okay, so I just went looking for the read_SSSR() function because
> I wanted to know how it was defined. I just discovered that this
> driver is the same as drivers/spi/spi-pxa2xx.c with a PCI front end
> bolted on.

Quite possible - I wans't aware of that but they may well come from
the same origin.
 
> > +late_initcall(intel_mid_ssp_spi_init);
> 
> Why late_initcall()? module_init() should be sufficient. Or better yet
> replace the init and exit functions with module_pci_driver()

Thats a legacy of the old SPI code not handling bus and device
registration in random orders. So it's no longer needed I believe.

Alan

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d