From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 6 Dec 2012 19:02:31 +0100 Subject: [U-Boot] [PATCH 1/3 V2] EHCI: Exynos: Add fdt support In-Reply-To: References: <1354775556-23212-1-git-send-email-rajeshwari.s@samsung.com> <201212061839.45249.marex@denx.de> Message-ID: <201212061902.31946.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Simon Glass, [...] > > [...] > > > > error output should be really puts() or printf() ... > > Ick that bloats the code badly for an uncommon case. Would really > prefer to avoid this. What do you mean? Are you saying this debug() is correct and this is triggered often? How come? > > You can also use errno.h instead of -1. > > True, it might help debugging, although many times it is hard to map > the error onto a suitable number designed for Linux. This 'return -1' > is pretty common in U-Boot (generic error). I know, but it'd be nice if this changed. Just a suggestion. Best regards, Marek Vasut