From: mdroth <mdroth@linux.vnet.ibm.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value
Date: Thu, 6 Dec 2012 16:24:43 -0600 [thread overview]
Message-ID: <20121206222443.GC30686@vm> (raw)
In-Reply-To: <1354828325-16568-3-git-send-email-imammedo@redhat.com>
On Thu, Dec 06, 2012 at 10:12:05PM +0100, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> v2:
> - replace visit_type_freq() with visit_type_unit_suffixed_int()
> in x86_cpuid_set_tsc_freq()
> ---
> target-i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index c6c2ca0..b7f0aba 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1195,7 +1195,7 @@ static void x86_cpuid_set_tsc_freq(Object *obj, Visitor *v, void *opaque,
> const int64_t max = INT64_MAX;
> int64_t value;
>
> - visit_type_int(v, &value, name, errp);
> + visit_type_unit_suffixed_int(v, &value, name, 1000, errp);
> if (error_is_set(errp)) {
> return;
> }
> --
> 1.7.11.7
>
next prev parent reply other threads:[~2012-12-06 22:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 21:12 [Qemu-devel] [PATCH 0/2] introduce visitor for parsing suffixed integer Igor Mammedov
2012-12-06 21:12 ` [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string Igor Mammedov
2012-12-06 22:24 ` mdroth
2012-12-07 11:55 ` Eduardo Habkost
2012-12-07 18:57 ` Andreas Färber
2012-12-07 19:53 ` Eduardo Habkost
2012-12-10 16:01 ` Igor Mammedov
2012-12-10 17:27 ` mdroth
2012-12-10 19:03 ` Igor Mammedov
2012-12-06 21:12 ` [Qemu-devel] [PATCH 2/2] target-i386: use visit_type_unit_suffixed_int() to parse tsc_freq property value Igor Mammedov
2012-12-06 22:24 ` mdroth [this message]
2012-12-07 11:57 ` Eduardo Habkost
2012-12-07 19:00 ` Andreas Färber
2012-12-07 20:09 ` Eduardo Habkost
2012-12-10 16:13 ` Igor Mammedov
2012-12-10 17:21 ` mdroth
2012-12-10 20:47 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206222443.GC30686@vm \
--to=mdroth@linux.vnet.ibm.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.