From: Alan Cox <alan@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
linux-serial@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <lenb@kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Rickard Andersson <rickard.andersson@stericsson.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/2] tty: serial core: use the ACPI PM state defines
Date: Thu, 6 Dec 2012 23:36:00 +0000 [thread overview]
Message-ID: <20121206233600.7249c3f1@bob.linux.org.uk> (raw)
In-Reply-To: <CACRpkdaFaL9jm9Je2NO_m+=-JgN02_s8=W8=t+TcHxn0ro2ojg@mail.gmail.com>
On Thu, 6 Dec 2012 20:31:15 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Dec 6, 2012 at 8:31 PM, Alan Cox <alan@linux.intel.com> wrote:
>
> > Almost none of the platforms using the serial driver even have ACPI
> > so this seems to be an obfuscation of a simple numbering system for
> > a subsystem specific set of definitions that may or may not fit in
> > future.
>
> OK so we need to get away from using the ACPI numbering scheme.
> What about we define something in the <linux/tty.h> file instead
> and delete the paragraph from the documentation saying it is related
> to ACPI? (Will try this next.)
What about just using 0, 1, 2, 3 to indicate states similar to D0-D3
which as a base concept everyone is familiar with ?
If we need something more than that, then can we talk about what the
actual extra non 0/3 states needed are and how to get a generic
meaningful definition, or indeed whether a number rather than flag bits
makes sense ?
Start with the driver/platform that causes the concern and then the
rest is probably blindingly obvious.
Alan
next prev parent reply other threads:[~2012-12-06 23:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 18:46 [PATCH 2/2] tty: serial core: use the ACPI PM state defines Linus Walleij
2012-12-06 19:31 ` Alan Cox
2012-12-06 19:31 ` Linus Walleij
2012-12-06 19:40 ` Alan Cox
2012-12-06 20:05 ` Linus Walleij
2012-12-06 20:57 ` Rafael J. Wysocki
2012-12-06 23:36 ` Alan Cox [this message]
2012-12-07 10:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121206233600.7249c3f1@bob.linux.org.uk \
--to=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rickard.andersson@stericsson.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.