From: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
To: Adrian Chadd <adrian@freebsd.org>
Cc: Felix Fietkau <nbd@openwrt.org>, <linux-wireless@vger.kernel.org>,
<linville@tuxdriver.com>, <rodrigue@qca.qualcomm.com>
Subject: Re: [PATCH] Revert "ath9k_hw: Update AR9003 high_power tx gain table"
Date: Fri, 7 Dec 2012 11:23:26 +0530 [thread overview]
Message-ID: <20121207055322.GA27229@hemis.qca.qualcomm.com> (raw)
In-Reply-To: <CAJ-Vmonvo9tq4ZF8WosnXNQq=ArqoDuKtz5y8UnFoWfYAikMxQ@mail.gmail.com>
On Thu, Dec 06, 2012 at 11:35:33AM -0800, Adrian Chadd wrote:
> On 6 December 2012 09:40, Felix Fietkau <nbd@openwrt.org> wrote:
> > This reverts commit f74b9d365ddd33a375802b064f96a5d0e99af7c0.
> >
> > Turns out reverting commit a240dc7b3c7463bd60cf0a9b2a90f52f78aae0fd
> > "ath9k_hw: Updated AR9003 tx gain table for 5GHz" was not enough to
> > bring the tx power back to normal levels on devices like the
> > Buffalo WZR-HP-G450H, this one needs to be reverted as well.
> >
> > This revert improves tx power by ~10 db on that device
>
> Did anyone figure out why this was happening?
>
> Maybe we should look at the HAL commits around the same time to see if
> someone changed the programming - eg, assuming TPC is always on, or
> the 2 stream / 3 stream reduction PHY register, or such.
>
Generally we update initval taken from Systems team. We might have missed to
program the some registers while updating initvals. I prefer to fix the missing
portion rather than reverting ini tables. Otherwise we end up with using
older initvals and hard to debug hw related issues.
-Rajkumar
next prev parent reply other threads:[~2012-12-07 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 17:40 [PATCH] Revert "ath9k_hw: Update AR9003 high_power tx gain table" Felix Fietkau
2012-12-06 19:35 ` Adrian Chadd
2012-12-07 5:53 ` Rajkumar Manoharan [this message]
2012-12-07 11:47 ` Felix Fietkau
2012-12-07 2:44 ` Sujith Manoharan
2012-12-07 9:04 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121207055322.GA27229@hemis.qca.qualcomm.com \
--to=rmanohar@qca.qualcomm.com \
--cc=adrian@freebsd.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=nbd@openwrt.org \
--cc=rodrigue@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.