From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad@kernel.org>
Subject: Re: [PATCH 1/4] stubdom: Change vTPM shared page ABI
Date: Fri, 7 Dec 2012 16:25:37 -0500
Message-ID: <20121207212536.GE9664@phenom.dumpdata.com>
References: <50B4D060.9070403@jhuapl.edu>
	<1354029286-17652-1-git-send-email-dgdegra@tycho.nsa.gov>
	<1354029286-17652-2-git-send-email-dgdegra@tycho.nsa.gov>
	<50B76DBB.90504@jhuapl.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <50B76DBB.90504@jhuapl.edu>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Matthew Fioravante <matthew.fioravante@jhuapl.edu>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>, "Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

> >+   snprintf(path, 512, "backend/vtpm/%u/%u/feature-protocol-v2", (unsigned int) tpmif->domid, tpmif->handle);
> >+   if ((err = xenbus_write(XBT_NIL, path, "1")))
> >+   {
> >+      /* if we got an error here we should carefully remove the interface and then return */
> >+      TPMBACK_ERR("Unable to write feature-protocol-v2 node: %s\n", err);
> >+      free(err);
> >+      remove_tpmif(tpmif);
> >+      goto error_post_irq;
> >+   }
> >+
> My preference is still to do away with the versioning stuff since
> tpm is just getting released. Its not even in linux yet so there is
> no confusion. We can even merge the linux patches together and
> resubmit as one if thats preferrable. Konrad, Ian, your final votes
> on that?

I am up for just removing the versioning stuff - and if one really
wants to be fool-proof - rename the 'backend/vtpm' to 'backend/vtpm2'
Perhaps?