From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754908Ab2LGXRf (ORCPT ); Fri, 7 Dec 2012 18:17:35 -0500 Received: from mail-qa0-f53.google.com ([209.85.216.53]:54944 "EHLO mail-qa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754692Ab2LGXRe (ORCPT ); Fri, 7 Dec 2012 18:17:34 -0500 Date: Fri, 7 Dec 2012 23:17:30 +0000 From: Cong Ding To: "H. Peter Anvin" Cc: Thomas Gleixner , Ingo Molnar , x86@kernel.org, Masami Hiramatsu , linux-kernel@vger.kernel.org Subject: [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Message-ID: <20121207231729.GC6179@gmail.com> References: <1354920151-4461-1-git-send-email-dinggnu@gmail.com> <3c1e54bc-31ec-4a38-b6d3-58b25760f9cb@email.android.com> <20121207224949.GA6179@gmail.com> <50C27410.7050101@zytor.com> <20121207230302.GB6179@gmail.com> <50C27665.4090206@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50C27665.4090206@zytor.com> User-Agent: Mutt/1.5.20 (2009-12-10) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 07, 2012 at 03:06:13PM -0800, H. Peter Anvin wrote: > On 12/07/2012 03:03 PM, Cong Ding wrote: > >On Fri, Dec 07, 2012 at 02:56:16PM -0800, H. Peter Anvin wrote: > >>On 12/07/2012 02:49 PM, Cong Ding wrote: > >>>On Fri, Dec 07, 2012 at 02:45:43PM -0800, H. Peter Anvin wrote: > >>>>Patch description please? > >>>there are 2 consts in the definition of one variable > >>> > >> > >>Please put in an actual patch description. The first line (subject > >>line) is a title; the patch should make sense without it. > >sorry for that. so like this is fine? > > > > Well, except that typically you should explain which variable it is. > Yes, it is obvious if you look at the patch, but you're making the > reader spend a few more moments than necessary. > > Also, you should explain what the harm is -- if it breaks anything > or is just a cosmetic issue. sorry again for lacking of experience... and I missed another same error, so send version 2. - cong --- >>From 6cf729b913287a6fc06325ca75ccf0efff9274e8 Mon Sep 17 00:00:00 2001 From: Cong Ding Date: Fri, 7 Dec 2012 23:14:32 +0000 Subject: [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const fix the following sparse warning: arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const for variable inat_escape_tables, inat_group_tables, and inat_avx_tables Signed-off-by: Cong Ding --- arch/x86/tools/gen-insn-attr-x86.awk | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/x86/tools/gen-insn-attr-x86.awk b/arch/x86/tools/gen-insn-attr-x86.awk index ddcf39b..987c7b2 100644 --- a/arch/x86/tools/gen-insn-attr-x86.awk +++ b/arch/x86/tools/gen-insn-attr-x86.awk @@ -356,7 +356,7 @@ END { exit 1 # print escape opcode map's array print "/* Escape opcode map array */" - print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]" \ + print "const insn_attr_t *inat_escape_tables[INAT_ESC_MAX + 1]" \ "[INAT_LSTPFX_MAX + 1] = {" for (i = 0; i < geid; i++) for (j = 0; j < max_lprefix; j++) @@ -365,7 +365,7 @@ END { print "};\n" # print group opcode map's array print "/* Group opcode map array */" - print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\ + print "const insn_attr_t *inat_group_tables[INAT_GRP_MAX + 1]"\ "[INAT_LSTPFX_MAX + 1] = {" for (i = 0; i < ggid; i++) for (j = 0; j < max_lprefix; j++) @@ -374,7 +374,7 @@ END { print "};\n" # print AVX opcode map's array print "/* AVX opcode map array */" - print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX + 1]"\ + print "const insn_attr_t *inat_avx_tables[X86_VEX_M_MAX + 1]"\ "[INAT_LSTPFX_MAX + 1] = {" for (i = 0; i < gaid; i++) for (j = 0; j < max_lprefix; j++) -- 1.7.4.5