All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Ding <dinggnu@gmail.com>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	"yrl.pp-manager.tt@hitachi.com" <yrl.pp-manager.tt@hitachi.com>
Subject: [PATCH v3] x86: fix the error of using "const" in gen-insn-attr-x86.awk
Date: Sun, 9 Dec 2012 08:21:04 +0000	[thread overview]
Message-ID: <20121209082103.GA9181@gmail.com> (raw)
In-Reply-To: <50C420A7.9090108@hitachi.com>

>From 9523e1de9d2771dc66a5b645651fc9f4745eb685 Mon Sep 17 00:00:00 2001
From: Cong Ding <dinggnu@gmail.com>
Date: Sun, 9 Dec 2012 08:06:20 +0000
Subject: [PATCH v3] x86: fix the error of using "const" in gen-insn-attr-x86.awk

x86: fix the error of using "const" in gen-insn-attr-x86.awk

The original version code causes following sparse warnings:
arch/x86/lib/inat-tables.c:1080:25: warning: duplicate const
arch/x86/lib/inat-tables.c:1095:25: warning: duplicate const
arch/x86/lib/inat-tables.c:1118:25: warning: duplicate const

for the variables inat_escape_tables, inat_group_tables, and inat_avx_tables
in the code generated by gen-insn-attr-x86.awk.

The author Masami Hiramutsu says here is to make both the value pointed by the
pointers and the pointers itself read-only, so we move the "const" to be after
the "*".

Signed-off-by: Cong Ding <dinggnu@gmail.com>
Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
---
 arch/x86/tools/gen-insn-attr-x86.awk |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/tools/gen-insn-attr-x86.awk b/arch/x86/tools/gen-insn-attr-x86.awk
index ddcf39b..e6773dc 100644
--- a/arch/x86/tools/gen-insn-attr-x86.awk
+++ b/arch/x86/tools/gen-insn-attr-x86.awk
@@ -356,7 +356,7 @@ END {
 		exit 1
 	# print escape opcode map's array
 	print "/* Escape opcode map array */"
-	print "const insn_attr_t const *inat_escape_tables[INAT_ESC_MAX + 1]" \
+	print "const insn_attr_t * const inat_escape_tables[INAT_ESC_MAX + 1]" \
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < geid; i++)
 		for (j = 0; j < max_lprefix; j++)
@@ -365,7 +365,7 @@ END {
 	print "};\n"
 	# print group opcode map's array
 	print "/* Group opcode map array */"
-	print "const insn_attr_t const *inat_group_tables[INAT_GRP_MAX + 1]"\
+	print "const insn_attr_t * const inat_group_tables[INAT_GRP_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < ggid; i++)
 		for (j = 0; j < max_lprefix; j++)
@@ -374,7 +374,7 @@ END {
 	print "};\n"
 	# print AVX opcode map's array
 	print "/* AVX opcode map array */"
-	print "const insn_attr_t const *inat_avx_tables[X86_VEX_M_MAX + 1]"\
+	print "const insn_attr_t * const inat_avx_tables[X86_VEX_M_MAX + 1]"\
 	      "[INAT_LSTPFX_MAX + 1] = {"
 	for (i = 0; i < gaid; i++)
 		for (j = 0; j < max_lprefix; j++)
-- 
1.7.4.5


  reply	other threads:[~2012-12-09  8:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-07 22:42 [PATCH] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Cong Ding
2012-12-07 22:45 ` H. Peter Anvin
2012-12-07 22:49   ` Cong Ding
2012-12-07 22:56     ` H. Peter Anvin
2012-12-07 23:03       ` Cong Ding
2012-12-07 23:06         ` H. Peter Anvin
2012-12-07 23:17           ` [PATCH v2] " Cong Ding
2012-12-07 23:28             ` H. Peter Anvin
2012-12-08  0:04             ` [tip:x86/cleanups] x86: Remove duplicate "const" in gen-insn-attr-x86.awk tip-bot for Cong Ding
2012-12-09  5:24             ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Masami Hiramatsu
2012-12-09  8:21               ` Cong Ding [this message]
2012-12-10 21:17                 ` [tip:x86/cleanups] x86: Fix the error of using "const" in gen-insn-attr-x86.awk tip-bot for Cong Ding
2012-12-09  8:27               ` [PATCH v2] arch/x86/tools/gen-insn-attr-x86.awk: remove duplicate const Cong Ding
2012-12-09 15:50               ` H. Peter Anvin
2012-12-10  1:00                 ` Masami Hiramatsu
2012-12-10  1:03                   ` H. Peter Anvin
2012-12-10  1:27                     ` Masami Hiramatsu
2012-12-10  1:34                       ` H. Peter Anvin
2012-12-10  1:50                         ` Masami Hiramatsu
2012-12-10  1:56                           ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121209082103.GA9181@gmail.com \
    --to=dinggnu@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yrl.pp-manager.tt@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.