From: Cong Ding <dinggnu@gmail.com>
To: Steve Underwood <steveu@coppice.org>,
David Rowe <david@rowetel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jesper Juhl <jj@chaosbits.net>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: echo: remove unused variable
Date: Sun, 9 Dec 2012 15:19:09 +0000 [thread overview]
Message-ID: <20121209151909.GC25293@gmail.com> (raw)
In-Reply-To: <1354584111-1513-1-git-send-email-dinggnu@gmail.com>
ping!
- cong
On Tue, Dec 04, 2012 at 01:21:44AM +0000, Cong Ding wrote:
> the variable j isn't used in the loop
>
> Signed-off-by: Cong Ding <dinggnu@gmail.com>
> ---
> drivers/staging/echo/echo.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/echo/echo.c b/drivers/staging/echo/echo.c
> index ca87ce9..14dfd91 100644
> --- a/drivers/staging/echo/echo.c
> +++ b/drivers/staging/echo/echo.c
> @@ -119,7 +119,6 @@
> static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
> {
> int i;
> - int j;
> int offset1;
> int offset2;
> int factor;
> @@ -142,7 +141,7 @@ static inline void lms_adapt_bg(struct oslec_state *ec, int clean, int shift)
>
> /* asm("st:"); */
> n = ec->taps;
> - for (i = 0, j = offset2; i < n; i++, j++) {
> + for (i = 0; i < n; i++) {
> exp = *phist++ * factor;
> ec->fir_taps16[1][i] += (int16_t) ((exp + (1 << 14)) >> 15);
> }
> --
> 1.7.4.5
>
next prev parent reply other threads:[~2012-12-09 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-04 1:21 [PATCH] staging: echo: remove unused variable Cong Ding
2012-12-09 15:19 ` Cong Ding [this message]
2012-12-10 9:50 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209151909.GC25293@gmail.com \
--to=dinggnu@gmail.com \
--cc=david@rowetel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jj@chaosbits.net \
--cc=linux-kernel@vger.kernel.org \
--cc=steveu@coppice.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.