All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <groeck-dsl@sbcglobal.net>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: anish kumar <anish198519851985@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	linux-kernel@vger.kernel.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] gpio: export 'debounce' attribute if supported by the gpio chip
Date: Sun, 9 Dec 2012 09:07:54 -0800	[thread overview]
Message-ID: <20121209170754.GA27468@roeck-us.net> (raw)
In-Reply-To: <20121209110319.459a762a@pyramind.ukuu.org.uk>

On Sun, Dec 09, 2012 at 11:03:19AM +0000, Alan Cox wrote:
> On Sun, 09 Dec 2012 01:58:19 -0800
> anish kumar <anish198519851985@gmail.com> wrote:
> 
> > On Fri, 2012-12-07 at 16:49 +0000, Alan Cox wrote:
> > > > I could imagine declaring the activity request buttons to be "input", but for
> > > > presence detects it is a bit far fetched and would add too much complexity.
> > > 
> > > Android tries to address this with its switch class driver, but I'm not
> > > sure its actually got anything over making them input devices.
> > 
> > Sorry for not understanding the context here.How the debounce sysfs
> > added by Guenter has anything to do with switch driver in android?
> 
> The other more general option is to make the input layer do the debounce
> and make them all inputs rather than just relying on any gpio layer
> support.
> 
The gpio pins I am dealing with are provided by an FPGA which is used on various
boards. While the gpio access registers are always the same, the actual usage is
board specific. This means I either need to write ugly code, or use the gpio
subsystem to provide access to the gpio pins. Ugly code is out of the question,
which means I'll need gpio support.

Anyway, I want to keep things simple, not add unnecessary complexity. Having to
go through the input subsystem just to be able to support debounce on a couple
of input pins doesn't really sound simple. Guess I'll have to find another
solution if the patch is not accepted. Maybe I'll add a "debounce" property to
the gpio driver's of properties.

Thanks,
Guenter

  reply	other threads:[~2012-12-09 17:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-06  6:32 [PATCH] gpio: export 'debounce' attribute if supported by the gpio chip Guenter Roeck
2012-12-07  8:07 ` Linus Walleij
2012-12-07 14:59   ` Guenter Roeck
2012-12-07 16:20     ` Guenter Roeck
2012-12-07 16:49     ` Alan Cox
2012-12-09  9:58       ` anish kumar
2012-12-09 11:03         ` Alan Cox
2012-12-09 17:07           ` Guenter Roeck [this message]
2012-12-09 22:36             ` Grant Likely
2012-12-10 10:11             ` Linus Walleij
2012-12-10 10:04       ` Linus Walleij
2012-12-10 18:48         ` Guenter Roeck
2012-12-10 19:37           ` anish singh
2012-12-13 17:08             ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121209170754.GA27468@roeck-us.net \
    --to=groeck-dsl@sbcglobal.net \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=anish198519851985@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.