From: Michal Marek <mmarek@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] scripts/tags.sh: Support compiled source
Date: Sun, 9 Dec 2012 18:53:15 +0100 [thread overview]
Message-ID: <20121209175315.GD29331@pobox.suse.cz> (raw)
In-Reply-To: <1354557873-21889-2-git-send-email-js1304@gmail.com>
On Tue, Dec 04, 2012 at 03:04:33AM +0900, Joonsoo Kim wrote:
> We usually have interst in compiled files only,
> because they are strongly related to individual's work.
> Current tags.sh can't select compiled files, so support it.
>
> We can use this functionality like below.
> "make cscope O=. SRCARCH=xxxx COMPILED_SOURCE=compiled"
>
> It must be executed after building the kernel.
>
> Signed-off-by: Joonsoo Kim <js1304@gmail.com>
> ---
> v2: change bash specific '[[]]' to 'case in' statement.
> use COMPILED_SOURCE env var, instead of abusing SUBARCH
Looks much better, I have only one minor nitpick:
> + if [ "$COMPILED_SOURCE" = "compiled" ]; then
> + all_compiled_sources
Please change it to -n "$COMPILED_SOURCE", so that COMPILED_SOURCE=1
works as well.
Michal
next prev parent reply other threads:[~2012-12-09 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 18:04 [PATCH v2 1/2] scripts/tags.sh: Support subarch for ARM Joonsoo Kim
2012-12-03 18:04 ` [PATCH v2 2/2] scripts/tags.sh: Support compiled source Joonsoo Kim
2012-12-09 17:53 ` Michal Marek [this message]
2012-12-09 17:51 ` [PATCH v2 1/2] scripts/tags.sh: Support subarch for ARM Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121209175315.GD29331@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.