From: Dave Chinner <david@fromorbit.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Fix re-use of EWOULDBLOCK during read on dm-mirror
Date: Mon, 10 Dec 2012 12:12:01 +1100 [thread overview]
Message-ID: <20121210011201.GI15784@dastard> (raw)
In-Reply-To: <20121207095326.GI27172@dastard>
On Fri, Dec 07, 2012 at 08:53:26PM +1100, Dave Chinner wrote:
> On Thu, Dec 06, 2012 at 05:39:17PM -0500, Jeff Mahoney wrote:
> > When using lvconvert to convert a linear mapping to a dm-raid1 mirror,
> > we encountered issues where the log would be flooded with messages like:
> >
> > metadata I/O error: block 0xee7060 ("xfs_trans_read_buf") error 11 numblks 8
> >
> > The cause is that dm-mirror (and striping, and others) will return
> > -EWOULDBLOCK for readahead requests while the mirror is rebuilding.
>
> That's nasty - since when has DM been doing this? I doubt anything
> handles a EAGAIN error from the storage layer properly - it's not
> an error the filesystem expects from the lower layers at all.
Wow, it's been doing this since at least 2008 - it's taken the
best part of 5 years for someone to trip over this.....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-12-10 1:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 22:39 [PATCH] xfs: Fix re-use of EWOULDBLOCK during read on dm-mirror Jeff Mahoney
2012-12-07 9:53 ` Dave Chinner
2012-12-10 1:12 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210011201.GI15784@dastard \
--to=david@fromorbit.com \
--cc=jeffm@suse.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.