From: Antonio Quartulli <antonio@open-mesh.com>
To: Nicolas Cavallari <Nicolas.Cavallari@lri.fr>
Cc: Johannes Berg <johannes@sipsolutions.net>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] mac80211: in AD-HOC mode wait for the AUTH response
Date: Mon, 10 Dec 2012 11:49:37 +0100 [thread overview]
Message-ID: <20121210104937.GA26638@open-mesh.com> (raw)
In-Reply-To: <50C5BCC3.8090809@lri.fr>
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
On Mon, Dec 10, 2012 at 11:43:15 +0100, Nicolas Cavallari wrote:
> > - if (auth && !sdata->u.ibss.auth_frame_registrations) {
> > + if (!sdata->u.ibss.auth_frame_registrations) {
> > ibss_dbg(sdata,
> > "TX Auth SA=%pM DA=%pM BSSID=%pM (auth_transaction=1)\n",
> > sdata->vif.addr, addr, sdata->u.ibss.bssid);
>
> If userspace registered for auth frames, then we shouldn't wait for auth responses,
> as this code will never see them.
>
Correct. I think in this case the station should immediately be authenticated in
this point using an else branch.
> I'm also curious about compatibility with the current wpa_supplicant which does not know
> about that new event.
Yeah. A patch has already been prepared, I'll send it once this patchset gets
accepted.
Thank you for reviewing!
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-12-10 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 10:21 [PATCH 1/2] cfg80211: add the new IBSS_STA event Antonio Quartulli
2012-12-10 10:21 ` [PATCH] mac80211: in AD-HOC mode wait for the AUTH response Antonio Quartulli
2012-12-10 10:43 ` Nicolas Cavallari
2012-12-10 10:49 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210104937.GA26638@open-mesh.com \
--to=antonio@open-mesh.com \
--cc=Nicolas.Cavallari@lri.fr \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.