From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs: simplify the fallocate path
Date: Mon, 10 Dec 2012 05:52:12 -0500 [thread overview]
Message-ID: <20121210105211.GA2794@infradead.org> (raw)
In-Reply-To: <20121210020956.GN15784@dastard>
On Mon, Dec 10, 2012 at 01:09:56PM +1100, Dave Chinner wrote:
> You don't use this flag anywhere ;)
Fixed.
> While I like most of this series, I don't really like the
> duplication of this piece of code. It seems to me that a simple
> helper like:
I had that in a previous version, but it seemed uglier than just
opencoding it. I'll give it another try, maybe I can come up
with something nicer now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-12-10 10:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-08 12:08 [PATCH 0/5] refactor the preallocation and hole punching code Christoph Hellwig
2012-12-08 12:08 ` [PATCH 1/5] xfs: remove the unused XFS_ATTR_NONBLOCK flag Christoph Hellwig
2012-12-08 12:08 ` [PATCH 2/5] xfs: always take the iolock around xfs_setattr_size Christoph Hellwig
2012-12-08 12:08 ` [PATCH 3/5] xfs: always hold the iolock when calling xfs_change_file_space Christoph Hellwig
2012-12-08 12:08 ` [PATCH 4/5] xfs: simplify the fallocate path Christoph Hellwig
2012-12-10 2:09 ` Dave Chinner
2012-12-10 10:52 ` Christoph Hellwig [this message]
2012-12-08 12:08 ` [PATCH 5/5] xfs: fold xfs_change_file_space into xfs_ioc_space Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2013-10-12 7:55 [PATCH 0/5] refactor the preallocation and hole punching code Christoph Hellwig
2013-10-12 7:55 ` [PATCH 4/5] xfs: simplify the fallocate path Christoph Hellwig
2013-10-14 5:04 ` Dave Chinner
2013-10-14 7:30 ` Christoph Hellwig
2013-10-14 20:03 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210105211.GA2794@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.