From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stephane Eranian <eranian@google.com>,
namhyung.kim@lge.com
Subject: Re: [PATCH 1/4] perf hists: Exchange order of comparing items when collapsing hists
Date: Mon, 10 Dec 2012 14:44:34 +0100 [thread overview]
Message-ID: <20121210134434.GA6416@krava.brq.redhat.com> (raw)
In-Reply-To: <1355128197-18193-2-git-send-email-namhyung@kernel.org>
On Mon, Dec 10, 2012 at 05:29:54PM +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@lge.com>
>
> When comparing entries for collapsing put the given entry first, and
> then the iterated entry. This is not the case of hist_entry__cmp()
> when called if given sort keys don't require collapsing. So change
> the order for the sake of consistency. It will be required for
> matching and/or linking multiple hist entries.
>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Stephane Eranian <eranian@google.com>
> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Acked-by: Jiri Olsa <jolsa@redhat.com>
next prev parent reply other threads:[~2012-12-10 13:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 8:29 [PATCH 0/4] perf hists: Changes on hists__{match,link} (v4) Namhyung Kim
2012-12-10 8:29 ` [PATCH 1/4] perf hists: Exchange order of comparing items when collapsing hists Namhyung Kim
2012-12-10 13:44 ` Jiri Olsa [this message]
2012-12-12 15:29 ` Arnaldo Carvalho de Melo
2012-12-12 15:56 ` Jiri Olsa
2012-12-12 16:14 ` Arnaldo Carvalho de Melo
2013-01-25 10:47 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-12-10 8:29 ` [PATCH 2/4] perf hists: Link hist entries before inserting to an output tree Namhyung Kim
2013-01-25 10:48 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-12-10 8:29 ` [PATCH 3/4] perf diff: Use internal rb tree for compute resort Namhyung Kim
2013-01-25 10:49 ` [tip:perf/core] " tip-bot for Namhyung Kim
2012-12-10 8:29 ` [PATCH 4/4] perf test: Add a test case for hists__{match,link} Namhyung Kim
2013-01-25 10:51 ` [tip:perf/core] perf test: Add a test case for hists__{match, link} tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210134434.GA6416@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.