From: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
To: qemu-devel@nongnu.org
Cc: "Johnson, Eric" <ericj@mips.com>, Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH] target-mips: Use EXCP_SC rather than a magic number
Date: Tue, 11 Dec 2012 00:15:55 +0800 [thread overview]
Message-ID: <20121210161555.GA44699@cs.nctu.edu.tw> (raw)
From the discussion on the ML [1], the exception limit defined by
magic number 0x100 is actually EXCP_SC defined in cpu.h. Replace the
magic number with EXCP_SC. Remove "#if 1 .. #endif" as well.
[1] http://lists.gnu.org/archive/html/qemu-devel/2012-11/msg03080.html
Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
---
target-mips/op_helper.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c
index f45d494..98a445c 100644
--- a/target-mips/op_helper.c
+++ b/target-mips/op_helper.c
@@ -39,10 +39,10 @@ static inline void QEMU_NORETURN do_raise_exception_err(CPUMIPSState *env,
uintptr_t pc)
{
TranslationBlock *tb;
-#if 1
- if (exception < 0x100)
+ if (exception < EXCP_SC) {
qemu_log("%s: %d %d\n", __func__, exception, error_code);
-#endif
+ }
+
env->exception_index = exception;
env->error_code = error_code;
--
1.7.3.4
next reply other threads:[~2012-12-10 16:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 16:15 陳韋任 (Wei-Ren Chen) [this message]
2012-12-20 1:23 ` [Qemu-devel] [PATCH] target-mips: Use EXCP_SC rather than a magic number 陳韋任 (Wei-Ren Chen)
2012-12-20 1:59 ` li guang
2012-12-20 2:14 ` 陳韋任 (Wei-Ren Chen)
2013-01-01 11:07 ` Aurelien Jarno
2013-01-01 11:03 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210161555.GA44699@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=aurelien@aurel32.net \
--cc=ericj@mips.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.