From: Allen Martin <amartin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Conflicting commits for seaboard USB keyboard handling
Date: Mon, 10 Dec 2012 11:25:04 -0800 [thread overview]
Message-ID: <20121210192504.GA25496@badger> (raw)
In-Reply-To: <CA+m5__JZooPJp+mP7i_sdu7eOV0HvkYqCYRnGC8JVSHvjhwwag@mail.gmail.com>
On Mon, Dec 10, 2012 at 08:59:59AM -0800, Tom Warren wrote:
> Albert,
>
> On Mon, Dec 10, 2012 at 9:25 AM, Tom Warren <twarren.nvidia@gmail.com> wrote:
> > Will do.
> >
> > On Sat, Dec 8, 2012 at 11:03 PM, Albert ARIBAUD
> > <albert.u.boot@aribaud.net> wrote:
> >> Hello,
> >>
> >> It seems like two commits 5ddcc38b (in u-boot, committed by Marek)
> >> 29f3e3f2 (in u-boot-arm, committed by Tom from u-boot-tegra) are
> >> conflicting on the seaboard configuration header file for USB (and
> >> possibly other areas).
>
> Looking at Allen's commit, it only added CONFIG_USB_KEYBOARD (plus a
> comment) to seaboard.h. That should be conflict-free with my rename of
> TEGRA20_ to TEGRA_ in seaboard.h. Looking at Allen's patchset (which
> is marked 'Awaiting upstream' in Patchwork, BTW), you can see that my
> patch had already been applied to Allen's source
> (CONFIG_TEGRA_KEYBOARD instead of CONFIG_TEGRA20_KEYBOARD precedes
> Allen's CONFIG_USB_KEYBOARD in seaboard.h).
>
> I pulled TOT u-boot/master, and both commits seem to be just fine for
> seaboard.h. It builds fine, too.
>
> Can you be more explicit about the exact conflict, including which
> exact repos & branches you are merging when you see the conflict?
I can see the conflict if I checkout u-boot-arm/master and then merge
u-boot-tegra/next and u-boot/master. If we pull the following commit
from u-boot/master into u-boot-tegra/next it helps:
5ddcc38 tegra: Enable USB keyboard
There's still a conflict between the LCD config file changes and the
USB keyboard config file changes, but it's pretty straightforward to
resolve.
-Allen
--
nvpublic
next prev parent reply other threads:[~2012-12-10 19:25 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 6:03 [U-Boot] Conflicting commits for seaboard USB keyboard handling Albert ARIBAUD
2012-12-10 16:25 ` Tom Warren
2012-12-10 16:59 ` Tom Warren
2012-12-10 19:25 ` Allen Martin [this message]
2012-12-10 21:15 ` Tom Warren
2012-12-10 21:51 ` Tom Warren
2012-12-11 19:02 ` Allen Martin
2012-12-15 16:41 ` Albert ARIBAUD
2012-12-17 22:13 ` Tom Warren
2012-12-17 22:22 ` Allen Martin
2012-12-18 16:43 ` Tom Warren
2012-12-18 18:06 ` Allen Martin
2012-12-18 23:59 ` Tom Warren
2012-12-19 1:08 ` Allen Martin
2012-12-19 6:04 ` Stephen Warren
2012-12-19 19:37 ` Albert ARIBAUD
2012-12-19 21:11 ` Allen Martin
2012-12-19 22:42 ` Albert ARIBAUD
2012-12-20 0:32 ` Allen Martin
2012-12-20 17:16 ` Tom Warren
2012-12-13 19:20 ` Albert ARIBAUD
2012-12-14 16:48 ` Tom Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121210192504.GA25496@badger \
--to=amartin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.