All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Joseph Salisbury <joseph.salisbury@canonical.com>,
	Ben Hutchings <ben@decadent.org.uk>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Herton Krzesinski <herton.krzesinski@canonical.com>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH -stable 1/1] freezer: PF_FREEZER_NOSIG should be cleared along with PF_NOFREEZE
Date: Mon, 10 Dec 2012 12:34:06 -0800	[thread overview]
Message-ID: <20121210203406.GB21258@kroah.com> (raw)
In-Reply-To: <20121207144922.GB6478@redhat.com>

On Fri, Dec 07, 2012 at 03:49:22PM +0100, Oleg Nesterov wrote:
> This patch is only for pre-v3.3 stable trees which backported
> b40a7959 "freezer: exec should clear PF_NOFREEZE along with PF_KTHREAD".
> v3.3+ doesn't need this fix.
> 
> b40a7959 is the trivial bugfix, but unfortunately I forgot that
> until 34b087e4 "freezer: kill unused set_freezable_with_signal()"
> there were another only-for-kernel-threads flag, PF_FREEZER_NOSIG,
> which should be cleared as well.
> 
> See https://bugs.launchpad.net/ubuntu/+source/v86d/+bug/1080530
> The freezer fails because it expects that a PF_FREEZER_NOSIG task
> doesn't need a signal. Before b40a7959 it wrongly succeeds leaving
> the PF_NOFREEZE | PF_FREEZER_NOSIG task unfrozen.
> 
> Reported-and-tested-by: Joseph Salisbury <joseph.salisbury@canonical.com>
> Cc: stable@vger.kernel.org # pre v3.3 if commit b40a7959 was taken

>From what I can tell, 3.0-stable didn't take this patch, so it should be
fine.  Ben, I don't know about 3.2, you should check this.

Oleg, thanks for doing this work, much appreciated.

greg k-h

      parent reply	other threads:[~2012-12-10 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50BF9CC2.7070705@canonical.com>
     [not found] ` <1354762294.17107.157.camel@deadeye.wl.decadent.org.uk>
2012-12-06 12:42   ` freezer: exec should clear PF_NOFREEZE along with PF_KTHREAD Oleg Nesterov
2012-12-06 20:44     ` Joseph Salisbury
2012-12-07 14:49       ` [PATCH -stable 0/1] freezer: PF_FREEZER_NOSIG should be cleared along with PF_NOFREEZE Oleg Nesterov
2012-12-07 14:49         ` [PATCH -stable 1/1] " Oleg Nesterov
2012-12-09 23:04           ` Ben Hutchings
2012-12-10 20:34           ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121210203406.GB21258@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ben@decadent.org.uk \
    --cc=herton.krzesinski@canonical.com \
    --cc=joseph.salisbury@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=rjw@sisk.pl \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.