From: Johan Hedberg <johan.hedberg@gmail.com>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Bluetooth: Don't send new commands before CC for reset is received
Date: Tue, 11 Dec 2012 09:32:10 +0200 [thread overview]
Message-ID: <20121211073210.GA2447@x220> (raw)
In-Reply-To: <1355148525-29379-2-git-send-email-szymon.janc@tieto.com>
Hi Szymon,
On Mon, Dec 10, 2012, Szymon Janc wrote:
> After sending reset command wait for its command complete event before
> sending next command. Some chips sends CC event for command received
> before reset if reset was send before chip replied with CC.
>
> < HCI Command: Reset (0x03|0x0003) plen 0 [hci0] 18.404612
> > HCI Event: Command Complete (0x0e) plen 4 [hci0] 18.405850
> Write Extended Inquiry Response (0x03|0x0052) ncmd 1
> Status: Success (0x00)
> < HCI Command: Read Local Supported Features (0x04|0x0003) plen 0 [hci0] 18.406079
> > HCI Event: Command Complete (0x0e) plen 4 [hci0] 18.407864
> Reset (0x03|0x0003) ncmd 1
> Status: Success (0x00)
> < HCI Command: Read Local Supported Features (0x04|0x0003) plen 0 [hci0] 18.408062
> > HCI Event: Command Complete (0x0e) plen 12 [hci0] 18.408835
>
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
> net/bluetooth/hci_event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 705078a..81b4448 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -2688,7 +2688,7 @@ static void hci_cmd_complete_evt(struct hci_dev *hdev, struct sk_buff *skb)
> if (ev->opcode != HCI_OP_NOP)
> del_timer(&hdev->cmd_timer);
>
> - if (ev->ncmd) {
> + if (ev->ncmd && !test_bit(HCI_RESET, &hdev->flags)) {
> atomic_set(&hdev->cmd_cnt, 1);
> if (!skb_queue_empty(&hdev->cmd_q))
> queue_work(hdev->workqueue, &hdev->cmd_work);
This looks fine to me though I'd consider adding a Cc: stable tag to it
and rename the summary to "Fix sending commands..." to make clear that
this is a fix.
Acked-by: Johan Hedberg <johan.hedberg@intel.com>
Johan
prev parent reply other threads:[~2012-12-11 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 14:08 [RFC] HCI commands flow fix Szymon Janc
2012-12-10 14:08 ` [RFC] Bluetooth: Don't send new commands before CC for reset is received Szymon Janc
2012-12-11 7:32 ` Johan Hedberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211073210.GA2447@x220 \
--to=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.