From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC v2 2/5] video: Add generic HDMI infoframe helpers Date: Tue, 11 Dec 2012 08:58:53 +0100 Message-ID: <20121211075853.GA27084@avionic-0098.adnet.avionic-design.de> References: <1354725944-1862-1-git-send-email-thierry.reding@avionic-design.de> <1354725944-1862-3-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1903908441==" Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.186]) by gabe.freedesktop.org (Postfix) with ESMTP id 14FA0E6288 for ; Mon, 10 Dec 2012 23:58:59 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1903908441== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 07, 2012 at 12:32:42PM -0200, Paulo Zanoni wrote: > 2012/12/5 Thierry Reding : [...] > > +ssize_t hdmi_spd_infoframe_pack(struct hdmi_spd_infoframe *frame, void= *buffer, > > + size_t size) > > +{ > > + u8 *ptr =3D buffer; > > + size_t length, i; > > + > > + if (!frame || !buffer) > > + return -EINVAL; > > + > > + length =3D 4 + frame->length; > > + > > + if (size < length) > > + return -ENOSPC; > > + > > + memset(buffer, 0, length); > > + > > + ptr[0] =3D frame->type; > > + ptr[1] =3D frame->version; > > + ptr[2] =3D frame->length; > > + ptr[3] =3D 0; /* checksum */ > > + > > + for (i =3D 0; i < sizeof(frame->vendor); i++) > > + ptr[4 + i] =3D frame->vendor[i]; > > + > > + for (i =3D 0; i < sizeof(frame->product); i++) > > + ptr[12 + i] =3D frame->product[i]; > > + > > + ptr[26] =3D frame->sdi; >=20 > Shouldn't this be ptr[28] ? Yes, you're absolutely right. By the way, I had to scroll through your reply several times before I found this single line. If you remove unneeded context when replying your comments are much easier to locate. Thierry --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQxue9AAoJEN0jrNd/PrOhk7QQAJW47mgnudZBnzXtX1ho7Ma2 usY4G+udWQZZEEiHjNIKyhOkAojcO9fTWrQPBMOuwnYPdRhi79lzUAOBHAYJ00cV 4g8zy9RQTT33YbGM5dkcIgHhydSuf/u0D/3c+m2amUjGiz16UfkM/plo6QnEE1kQ DthAplDsk8YMYxC9fHfPxTCJ/GjBJVedAygxyi6F4uMNsJQS2e/604ltif5mjo1Y GtEq0PtUMoRAj/9pqW6guF1BFSYl1WkyKt4iEyTRnOCndOVJloAL2mmPZOXqnP4G S8S1vYANntJTLX3Kzgn36G03w2G/+ntfTgLffkoqX47CNknu4vnMyqwtFwW4jeMb eGbHbGErG0E+31LiF9f9uAiYK0973fdYCo2LNkZaSx0J7ura2TJghksGhSDY2tKj 5Ph8E1kt7tJvISjiIz7IZMt8xtZEXJYkaQIb37BxaX50dqN4c/XAYhSWsvq4xllS 9JszjJ/JIUTVFFxn/GnWNKE3sDYGwNNKVjWK8dvbWzjkhXYLKcs/3UcWI+3oF4lZ TBohIcNcX4REbBDyPPaiqDZeb5RrsdmchV1cAkA/xXOHxqFdfaTR5RmOJE19AiDu HKrVdrV7eSFGzYuxScZdAIRb5p1r2nODICGkMHE6CbtvGrtztJiaP8YTM9OvbGuM nnJDkQT12hyumZVsd479 =PdNR -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR-- --===============1903908441== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1903908441==--