From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC] drm/i915: Use generic HDMI infoframe helpers Date: Tue, 11 Dec 2012 09:35:05 +0100 Message-ID: <20121211083505.GB27084@avionic-0098.adnet.avionic-design.de> References: <1354725944-1862-6-git-send-email-thierry.reding@avionic-design.de> <1354893089-3596-1-git-send-email-przanoni@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1378446191==" Return-path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by gabe.freedesktop.org (Postfix) with ESMTP id 56E2CE6288 for ; Tue, 11 Dec 2012 00:35:09 -0800 (PST) In-Reply-To: <1354893089-3596-1-git-send-email-przanoni@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: Paulo Zanoni , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1378446191== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SkvwRMAIpAhPCcCJ" Content-Disposition: inline --SkvwRMAIpAhPCcCJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 07, 2012 at 01:11:29PM -0200, Paulo Zanoni wrote: > From: Paulo Zanoni >=20 > Use the generic HDMI infoframe helpers to get rid of the duplicate > implementation in the i915 driver. >=20 > This patch is based on the initial patch by Thierry Reding, but with a > different approach. >=20 > TODO: > - The SDVO part is totally untested. I am not sure if the buffer > size on the SDVO code must be a multiple of 4. > - The HDMI part was tested only on SNB/CPT. > - The patch is forcing pixel_repeat to 1 so I can properly test the > patch. Remove this before the final version. > - The correctnes of this patch depends on a fix on patch "video: add > Generic HDMI infoframe helpers" >=20 > Signed-off-by: Paulo Zanoni Hi Paulo, This looks good to me in general. I still think that writing the infoframe to the registers could be refactored some more, but I suppose it could just as well be done in a separate patch. Or not. It's your code after all. Thierry --SkvwRMAIpAhPCcCJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJQxvA5AAoJEN0jrNd/PrOhgLAP/Aj6owqYX2xv/gCRN6q5us89 t+FdUm84B8gD70hpPioy8YceLNf8tmCtW8rmkzDTfmBi8qqqW/cTCoUgfOImYa0N +Ib0m69jcRWGWNSyiR8b7+Xd+NvipI++k5Yu3v8LjtiNWLx/vCK7bGA8QMm0JtCZ /tVlGuUlzd7KdDuqxrGOWdMbjQE9T+jzmpOgGIGtESH9Ewp1ZDuNDp1qSn8UrFkY nzNxvFiUqYnpExYp4bvES69xJbO5SjopmL7vndXVt1c04izI4wGTYj6rFmsjKwzF L/LiVYjv35WRcoji+gZWUob7RjNdiqITjvPkFhSjSme3FUR8AtIBU1e5or7WwBpi dS5Q592yjigQFm4+zJTT+UiW9wP/KkH3Cxfd9DZTxuLx9JZODydOq/0hJB9UZCq4 4V/NktI9FAANPmGhYRhPzSNtw/9NWDDnBqgZODpBVgL6g2RHb9i/4nISUeYmgNty koIGi5tf6NrN4mbi0zcPepLFO0RPxB1/Fb1EgTrl8lDvMRsnL6umgg+wUJTehk8r UVxZzyKrBr1LTRcRKnAbtppIDa4UGBIsRbZIPvjwmljCylXLuhjO3h/CGTgsQRwn R7ZM8l+bLQDq1E+m+jBUQj2sDRE627y8ekp1/i1tP84AYWCNj3b9UeTcA01oPM8w sLqs2uh+i7gfYGgOE/wj =0JxK -----END PGP SIGNATURE----- --SkvwRMAIpAhPCcCJ-- --===============1378446191== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1378446191==--