From: Grant Likely <grant.likely@secretlab.ca>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>,
g.liakhovetski@gmx.de, linux-media@vger.kernel.org
Cc: rob.herring@calxeda.com, thomas.abraham@linaro.org,
t.figa@samsung.com, sw0312.kim@samsung.com,
kyungmin.park@samsung.com, devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined
Date: Tue, 11 Dec 2012 08:42:56 +0000 [thread overview]
Message-ID: <20121211084256.E2CDF3E076D@localhost> (raw)
In-Reply-To: <1355168499-5847-3-git-send-email-s.nawrocki@samsung.com>
On Mon, 10 Dec 2012 20:41:28 +0100, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> If CONFIG_OF isn't defined, no declaration of of_get_parent will be found
> and compilation can fail. This patch adds a dummy inline function
> definition to fix the problem.
Where is this function getting called when CONFIG_OF is not defined? I
suspect that any code calling of_get_parent() should be CONFIG_OF
specific code and configured out when CONFIG_OF=n, but let me know if
I'm missing something.
g.
next prev parent reply other threads:[~2012-12-11 8:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 19:41 [PATCH RFC 00/13] Common video input interfaces bindings and V4L2 OF helpers Sylwester Nawrocki
[not found] ` <1355168499-5847-1-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-12-10 19:41 ` [PATCH RFC 01/13] i2c: add dummy inline functions for when CONFIG_OF_I2C(_MODULE) isn't defined Sylwester Nawrocki
2012-12-10 19:41 ` Sylwester Nawrocki
2012-12-11 8:39 ` Grant Likely
2012-12-10 19:41 ` [PATCH RFC 02/13] of: add a dummy inline function for when CONFIG_OF is not defined Sylwester Nawrocki
2012-12-10 19:41 ` Sylwester Nawrocki
2012-12-11 8:42 ` Grant Likely [this message]
2012-12-10 19:41 ` [PATCH RFC 05/13] of: Add empty for_each_available_child_of_node() macro definition Sylwester Nawrocki
2012-12-10 19:41 ` Sylwester Nawrocki
[not found] ` <1355168499-5847-6-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-12-11 8:57 ` Grant Likely
2012-12-11 8:57 ` Grant Likely
2012-12-11 16:09 ` Sylwester Nawrocki
2012-12-10 19:41 ` [PATCH RFC 03/13] OF: define of_*_cmp() macros also if CONFIG_OF isn't set Sylwester Nawrocki
[not found] ` <1355168499-5847-4-git-send-email-s.nawrocki-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-12-11 8:45 ` Grant Likely
2012-12-11 8:45 ` Grant Likely
2012-12-10 19:41 ` [PATCH RFC 04/13] OF: make a function pointer argument const Sylwester Nawrocki
2012-12-11 8:51 ` Grant Likely
2012-12-10 19:41 ` [PATCH RFC 06/13] of: Add empty of_find_device_by_node() function definition Sylwester Nawrocki
2012-12-11 8:59 ` Grant Likely
2012-12-11 8:59 ` Grant Likely
2012-12-10 19:41 ` [PATCH RFC 07/13] of: Add empty of_get_next_child() " Sylwester Nawrocki
2012-12-10 19:41 ` [PATCH RFC 08/13] media: add V4L2 DT binding documentation Sylwester Nawrocki
2012-12-15 21:13 ` [PATCH] [media] Add common binding documentation for video interfaces Sylwester Nawrocki
2012-12-18 17:14 ` Stephen Warren
[not found] ` <50D0A475.7010800-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2012-12-31 19:51 ` Sylwester Nawrocki
2012-12-31 19:51 ` Sylwester Nawrocki
2012-12-31 21:55 ` Rob Herring
2012-12-10 19:41 ` [PATCH RFC 09/13] media: add a V4L2 OF parser Sylwester Nawrocki
2012-12-10 19:41 ` [PATCH RFC 10/13] v4l2-of: Support variable length of data-lanes property Sylwester Nawrocki
2012-12-10 19:41 ` [PATCH RFC 11/13] v4l2-of: Add v4l2_of_parse_data_lanes() function Sylwester Nawrocki
2012-12-10 19:41 ` [PATCH RFC 12/13] v4l2-of: Corrected v4l2_of_parse_link() function declaration Sylwester Nawrocki
2012-12-10 19:41 ` [PATCH RFC 13/13] v4l2-of: Replace "remote" property with "remote-endpoint" Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121211084256.E2CDF3E076D@localhost \
--to=grant.likely@secretlab.ca \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=g.liakhovetski@gmx.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=s.nawrocki@samsung.com \
--cc=sw0312.kim@samsung.com \
--cc=t.figa@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.