From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Tue, 11 Dec 2012 10:13:36 -0800 Subject: [PATCH] drivers/pinctrl: grab default handles from device core In-Reply-To: <1355233246-16694-1-git-send-email-linus.walleij@stericsson.com> References: <1355233246-16694-1-git-send-email-linus.walleij@stericsson.com> Message-ID: <20121211181336.GD25714@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: > diff --git a/include/linux/device.h b/include/linux/device.h > index 86ef6ab..dc399ab 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -605,6 +606,8 @@ struct device_dma_parameters { > * @pm_domain: Provide callbacks that are executed during system suspend, > * hibernation, system resume and during runtime PM transitions > * along with subsystem-level and driver-level callbacks. > + * @pins: For device pin management. > + * See Documentation/pinctrl.txt for details. > * @numa_node: NUMA node this device is close to. > * @dma_mask: Dma mask (if dma'ble device). > * @coherent_dma_mask: Like dma_mask, but for alloc_coherent mapping as not all > @@ -656,6 +659,10 @@ struct device { > struct dev_pm_info power; > struct dev_pm_domain *pm_domain; > > +#ifdef CONFIG_PINCTRL > + struct dev_pin_info pins; > +#endif Can't you just make this a * to the structure, saving a bit of space for those that don't use this structure? Ok, it's only saving one pointer, so it's really not a big deal to me if you don't want to do this, just asking... Also, this will have to wait until after 3.8-rc1 before I can consider merging it, I'm a bit busy for the next two weeks at the least... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754412Ab2LKSNm (ORCPT ); Tue, 11 Dec 2012 13:13:42 -0500 Received: from mail-da0-f46.google.com ([209.85.210.46]:51830 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732Ab2LKSNk (ORCPT ); Tue, 11 Dec 2012 13:13:40 -0500 Date: Tue, 11 Dec 2012 10:13:36 -0800 From: Greg Kroah-Hartman To: Linus Walleij Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Felipe Balbi , Benoit Cousson , Dmitry Torokhov , Thomas Petazzoni , Mitch Bradley , Mark Brown , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Jean-Christophe PLAGNIOL-VILLARD , Rickard Andersson , Russell King Subject: Re: [PATCH] drivers/pinctrl: grab default handles from device core Message-ID: <20121211181336.GD25714@kroah.com> References: <1355233246-16694-1-git-send-email-linus.walleij@stericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1355233246-16694-1-git-send-email-linus.walleij@stericsson.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 11, 2012 at 02:40:46PM +0100, Linus Walleij wrote: > diff --git a/include/linux/device.h b/include/linux/device.h > index 86ef6ab..dc399ab 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -21,6 +21,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -605,6 +606,8 @@ struct device_dma_parameters { > * @pm_domain: Provide callbacks that are executed during system suspend, > * hibernation, system resume and during runtime PM transitions > * along with subsystem-level and driver-level callbacks. > + * @pins: For device pin management. > + * See Documentation/pinctrl.txt for details. > * @numa_node: NUMA node this device is close to. > * @dma_mask: Dma mask (if dma'ble device). > * @coherent_dma_mask: Like dma_mask, but for alloc_coherent mapping as not all > @@ -656,6 +659,10 @@ struct device { > struct dev_pm_info power; > struct dev_pm_domain *pm_domain; > > +#ifdef CONFIG_PINCTRL > + struct dev_pin_info pins; > +#endif Can't you just make this a * to the structure, saving a bit of space for those that don't use this structure? Ok, it's only saving one pointer, so it's really not a big deal to me if you don't want to do this, just asking... Also, this will have to wait until after 3.8-rc1 before I can consider merging it, I'm a bit busy for the next two weeks at the least... thanks, greg k-h