All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 06/10] lib: add ubiutils-common
Date: Tue, 11 Dec 2012 20:17:42 +0100	[thread overview]
Message-ID: <20121211191742.GA24155@pengutronix.de> (raw)
In-Reply-To: <20121211093528.GR10369@pengutronix.de>


[-- Attachment #1.1: Type: text/plain, Size: 811 bytes --]


> In barebox we have the strtoull_suffix function. We normally accept 'G',
> 'M' and 'k' suffixes. Restricting the ubi functions to '*iB' suffixes
> might be confusing for barebox users. Not accepting '*iB' suffixes might
> be confusing to UBI tool users. How about extending strtoull_suffix to
> accept '*iB' suffixes and use it here? It seems the all that's missing
> is to adjust *endp to skip the additional 'iB'

OK. It probably makes sense to move the ubiutils_print_bytes() function
then to misc.c also and completely get rif of ubiutils-common? What
would be a proper name for the function, printull_suffix? Or
ulltostr_suffix? :)

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 149 bytes --]

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-12-11 19:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-10  8:14 [PATCH 00/10] add ubiformat command Wolfram Sang
2012-12-10  8:14 ` [PATCH 01/10] mtd: move is_power_of_2() to a public place Wolfram Sang
2012-12-11  9:22   ` Sascha Hauer
2012-12-11 14:57     ` Wolfram Sang
2012-12-10  8:14 ` [PATCH 02/10] ubi: consolidate ubi-media.h Wolfram Sang
2012-12-10  8:14 ` [PATCH 03/10] ubi: bump ubi-media.h to newest version Wolfram Sang
2012-12-11  9:24   ` Sascha Hauer
2012-12-11 15:17     ` Wolfram Sang
2012-12-10  8:14 ` [PATCH 04/10] devfs & mtd: add MEMERASE ioctl support Wolfram Sang
2012-12-10  8:14 ` [PATCH 05/10] mtd: utils: apply macros for message printouts Wolfram Sang
2012-12-10  8:14 ` [PATCH 06/10] lib: add ubiutils-common Wolfram Sang
2012-12-11  9:35   ` Sascha Hauer
2012-12-11 19:17     ` Wolfram Sang [this message]
2012-12-12  9:08       ` Sascha Hauer
2012-12-10  8:14 ` [PATCH 07/10] lib: add libscan Wolfram Sang
2012-12-10  8:14 ` [PATCH 08/10] lib: add libubigen Wolfram Sang
2012-12-10  8:14 ` [PATCH 09/10] lib: add barebox version of libmtd Wolfram Sang
2012-12-10  8:14 ` [PATCH 10/10] commands: add ubiformat Wolfram Sang
2012-12-11  9:57   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211191742.GA24155@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.