All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default
Date: Tue, 11 Dec 2012 19:49:17 -0200	[thread overview]
Message-ID: <20121211214916.GA3871@amt.cnet> (raw)


RTC interrupt reinjection has no known negative effect. Lack of 
RTC interrupt reinjection, though, has negative effects: time drift
for Windows guests which use it as a timer source. 

Based on that, enable lost_tick_policy=slew option as default.

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index c79fca7..c9e007d 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -884,7 +884,7 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qemu_irq intercept_irq)
 static Property mc146818rtc_properties[] = {
     DEFINE_PROP_INT32("base_year", RTCState, base_year, 1980),
     DEFINE_PROP_LOSTTICKPOLICY("lost_tick_policy", RTCState,
-                               lost_tick_policy, LOST_TICK_DISCARD),
+                               lost_tick_policy, LOST_TICK_SLEW),
     DEFINE_PROP_END_OF_LIST(),
 };
 

             reply	other threads:[~2012-12-11 21:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-11 21:49 Marcelo Tosatti [this message]
2012-12-12  8:43 ` [Qemu-devel] [PATCH] RTC: enable lost_tick_policy=slew as default Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121211214916.GA3871@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.