All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liu Bo <bo.li.liu@oracle.com>
To: Josef Bacik <jbacik@fusionio.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: put delayed iput tracking list inside in-memory inode
Date: Wed, 12 Dec 2012 09:50:40 +0800	[thread overview]
Message-ID: <20121212015038.GD12318@liubo> (raw)
In-Reply-To: <20121211145750.GC3126@localhost.localdomain>

On Tue, Dec 11, 2012 at 09:57:50AM -0500, Josef Bacik wrote:
> On Fri, Nov 30, 2012 at 04:24:43AM -0700, Liu Bo wrote:
> > This can save us a dynamic memory allocation/free.
> > 
> 
> You can have multiple outstanding delayed iputs per inode, so this will result
> in inodes still being in use on unmount, so this isn't going to work.

Yeah, you're right, but what if we add a check

if (list_empty(&bi->iput_list))
	list_add(&bi->iput_list, &fs_info->iput_list));

Am I missing something?

thanks,
liubo

  reply	other threads:[~2012-12-12  1:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30 11:24 [PATCH] Btrfs: put delayed iput tracking list inside in-memory inode Liu Bo
2012-12-11 14:57 ` Josef Bacik
2012-12-12  1:50   ` Liu Bo [this message]
2012-12-12 14:47     ` Josef Bacik
2012-12-12 16:05       ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121212015038.GD12318@liubo \
    --to=bo.li.liu@oracle.com \
    --cc=jbacik@fusionio.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.